Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348445

Summary: Remove NON-NLS from "View Menu" string
Product: [Eclipse Project] Platform Reporter: Carolyn MacLeod <carolynmacleod4>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Remy Suen <remy.suen>
Severity: normal    
Priority: P3 CC: pwebster, remy.suen
Version: 4.1   
Target Milestone: 4.2 M1   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Localization patch v1 none

Description Carolyn MacLeod CLA 2011-06-06 13:53:59 EDT
Build id: I20110604-2201

In the method: org.eclipse.e4.ui.workbench.renderers.swt.StackRenderer.showMenuButton(MPart, CTabFolder, MMenu)
in the following line of code:
  ti.setToolTipText("View Menu"); //$NON-NLS-1$
the string "View Menu" *should* be NLS'ed.

If there is anything that depends on that string, the dependent code should be rewritten.
Comment 1 Remy Suen CLA 2011-06-28 08:45:09 EDT
Created attachment 198715 [details]
Localization patch v1

Patch to the externalize the string so that it can be translated.
Comment 2 Remy Suen CLA 2011-06-28 08:46:47 EDT
(In reply to comment #1)
> Created attachment 198715 [details]
> Localization patch v1

Fix released to CVS HEAD.

Thanks for finding this problem, Carolyn!
Comment 3 Remy Suen CLA 2012-01-30 17:25:17 EST
Verified by source inspection with I20120127-1145 on Windows 7.