Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348405

Summary:	preferences.js restructuring to support jsdoc
Product:	[ECD] Orion	Reporter:	John Arthorne <john.arthorne>
Component:	Client	Assignee:	John Arthorne <john.arthorne>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	simon_kaegi
Version:	0.2	Flags:	simon_kaegi: review+
Target Milestone:	0.2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John Arthorne

2011-06-06 10:38:22 EDT

In order to get documentation of preferences.js working I had to convert to using prototypes. Although this is essentially a doc change I would like someone to take a look at the result to double-check it.

Comment 1 John Arthorne

2011-06-06 15:37:32 EDT

Simon please take a look. Looking at the diff is useless because the entire file has changed. I have pushed it to this branch:

refs/remotes/origin/20110606-prefs-refactor

Comment 2 Simon Kaegi

2011-06-07 22:38:24 EDT

Thanks John. Looks good and have pushed. I had a conflict and had to do the merge but tried to amend the author. Hopefully I got it right.