Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348370

Summary:

Save does not work anymore by default, need to use a gmf globalAction

Product:

[Modeling] GMF-Tooling

Reporter:

Aurelien Pupier <apupier>

Component:

Core

Assignee:

Project Inbox <gmp.gmf-tooling-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

blocker

Priority:

CC:

mathieu.velten, mistria

Version:

unspecified

Target Milestone:

2.4

Hardware:

All

OS:

All

See Also:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=346648

Whiteboard:

Bug Depends on:

Bug Blocks:

346648

Attachments:

Description	Flags
add IgraphicalEdipart to react to globalActionId "save"	none

Description Aurelien Pupier

2011-06-06 05:22:59 EDT

Created attachment 197379 [details]
add IgraphicalEdipart to react to globalActionId "save"

Save does not work anymore by default, need to use a gmf globalAction in combination with the patch provided on bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=346648

Comment 1 Mickael Istria

2011-06-06 07:51:03 EDT

Just tried this patch and tests are still working well. It solves the "save" issue in the case of a selection change, and it is the only thing to modify in GMF Tooling.
Then I commit it.

Comment 2 Mickael Istria

2011-06-06 08:11:04 EDT

Committed

Comment 3 Mathieu Velten

2011-06-06 08:26:01 EDT

the most important part (for us at least) that allows the save action to react to property changes (like a move of a graphical element) has not been committed, is it normal ?

link to the patch :
https://bugs.eclipse.org/bugs/attachment.cgi?id=197081

we would really like to have this committed before indigo release, the tooling patch you committed can be easily "workarounded" manually, this one is not.

thanks.

Comment 4 Mickael Istria

2011-06-06 08:27:42 EDT

The patch for the property changed listener is not part of GMF-Tooling. It is part of GMF-Runtime. Bug #346648 tracks the Runtime part.

Comment 5 Michael Golubev

2011-07-13 19:45:51 EDT

version -> 2.4

Comment 6 Michael Golubev

2011-07-14 07:51:37 EDT

Rollback, Set target to 2.4 instead of accidenatlly set Version