Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348363

Summary:

'mnemonics' feature not considered when rendering menu items

Product:

[Eclipse Project] Platform

Reporter:

Dani Megert <daniel_megert>

Component:

Assignee:

Remy Suen <remy.suen>

Status:

VERIFIED FIXED

QA Contact:

Remy Suen <remy.suen>

Severity:

normal

Priority:

CC:

pwebster, remy.suen

Version:

4.1

Target Milestone:

4.2 M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
HandledContributionItem patch v1	none

Description Dani Megert

2011-06-06 04:47:03 EDT

I20110604-2201.

The last 3 items have no mnemonics. This looks OK in 3.7. Wonder why they are lost in 4.1.

Comment 1 Remy Suen

2011-06-29 12:46:36 EDT

I think the commands' 'mnemonic' attribute value is being ignored.

Comment 2 Remy Suen

2011-06-29 12:50:03 EDT

3.x trace:

Thread [main] (Suspended)	
	CommandContributionItem.updateMnemonic(String) line: 744	
	CommandContributionItem.updateMenuItem() line: 605	
	CommandContributionItem.update(String) line: 580	
	CommandContributionItem.fill(Menu, int) line: 490	
	ViewPane$PaneMenuManager(MenuManager).doItemFill(IContributionItem, int) line: 741	
	ViewPane$PaneMenuManager(MenuManager).update(boolean, boolean) line: 822	
	ViewPane$PaneMenuManager.update(boolean, boolean) line: 98	
	ViewPane$PaneMenuManager(MenuManager).handleAboutToShow() line: 474	
	MenuManager.access$1(MenuManager) line: 469	
	MenuManager$2.menuShown(MenuEvent) line: 495	
	TypedListener.handleEvent(Event) line: 247	
	EventTable.sendEvent(Event) line: 84	
	Menu(Widget).sendEvent(Event) line: 1053	
	Menu(Widget).sendEvent(int, Event, boolean) line: 1077	
	Menu(Widget).sendEvent(int) line: 1058	
	Shell(Control).WM_INITMENUPOPUP(int, int) line: 4864	
	Shell(Control).windowProc(int, int, int, int) line: 4540	
	Shell(Canvas).windowProc(int, int, int, int) line: 341	
	Shell(Decorations).windowProc(int, int, int, int) line: 1610	
	Shell.windowProc(int, int, int, int) line: 2060	
	Display.windowProc(int, int, int, int) line: 4970	
	OS.TrackPopupMenu(int, int, int, int, int, int, RECT) line: not available [native method]	
	Menu._setVisible(boolean) line: 256

Comment 3 Remy Suen

2011-06-29 13:37:54 EDT

Created attachment 198847 [details]
HandledContributionItem patch v1

Update the renderer to consider the 'mnemonics' feature of a menu element.

Comment 4 Remy Suen

2011-06-29 13:41:17 EDT

(In reply to comment #3)
> Created attachment 198847 [details]
> HandledContributionItem patch v1

Patch released to CVS HEAD.

Comment 5 Dani Megert

2011-07-27 08:26:10 EDT

Verified in I20110726-2200.