Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348356

Summary:

reduce the number of warnings in framework plugins

Product:

z_Archived

Reporter:

Frank Becker <eclipse>

Component:

Mylyn

Assignee:

Steffen Pingel <steffen.pingel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

trivial

Priority:

Version:

unspecified

Target Milestone:

3.7

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch V1	eclipse: review?
mylyn/context/zip	none
temporarily reverted changes	none

Description Frank Becker

2011-06-05 23:46:42 EDT

I try to reduce the warnings (API Problems, Java Problems and Plug-in Problems)

see bug# 348335 for the Bugzilla Plugin

Comment 1 Frank Becker

2011-06-06 15:47:01 EDT

Created attachment 197453 [details]
patch V1

Steffen,

can you please review before I commit this?

Comment 2 Frank Becker

2011-06-06 15:47:04 EDT

Created attachment 197454 [details]
mylyn/context/zip

Comment 3 Steffen Pingel

2011-06-09 10:30:29 EDT

Looks good to me but please do not apply this changes: TaskEditorCommentPart.java: keep call to EditorUtil.center() .

Comment 4 Frank Becker

2011-06-09 15:02:16 EDT

(In reply to comment #3)
> Looks good to me but please do not apply this changes:
> TaskEditorCommentPart.java: keep call to EditorUtil.center() .
What is the reason for this?

All other things are now in HEAD

Comment 5 Steffen Pingel

2011-06-09 17:57:40 EDT

(In reply to comment #4)
> (In reply to comment #3)
> > Looks good to me but please do not apply this changes:
> > TaskEditorCommentPart.java: keep call to EditorUtil.center() .
> What is the reason for this?

It's for backwards compatibility with Eclipse 3.4. While we don't officially support it anymore we are not making an effort to intentionally break it.

Comment 6 Sam Davis

2011-06-09 21:28:46 EDT

I'm now getting the following compiler error: "The type ServiceReference is not generic; it cannot be parameterized with arguments <?>." Could someone please tell me how to fix this?

Comment 7 Steffen Pingel

2011-06-10 04:53:44 EDT

Sam, which version of Eclipse are you targeting?

Comment 8 Sam Davis

2011-06-10 11:49:41 EDT

I am running and targetting 3.6.

Comment 9 Frank Becker

2011-06-10 15:58:40 EDT

We need to fix the ServiceReference problem.

Comment 10 Sam Davis

2011-06-10 16:05:29 EDT

The problem is at line 374 of TasksUiPlugin.

Comment 11 Frank Becker

2011-06-10 16:11:58 EDT

The fix is now in HEAD.

I changed

	private ServiceReference<?> proxyServiceReference;
	
to

	private ServiceReference proxyServiceReference;

The class ServiceReference was changed after 3.6.2 to be generic.

Sorry that I have introduce this problem but I use the 3.7 latest Milestone.

Comment 12 Sam Davis

2011-06-10 16:21:56 EDT

It works now. Thanks for fixing this Frank.

Comment 13 Steffen Pingel

2011-06-13 11:41:25 EDT

Created attachment 197898 [details]
temporarily reverted changes

Comment 14 Steffen Pingel

2011-06-13 13:00:06 EDT

I have temporarily reverted some changes that broke backwards compatibility and an existing integration. I'll re-apply this patch in a few weeks once we start refactoring internals for 3.7.

Comment 15 Sam Davis

2011-06-13 13:02:15 EDT

Steffen, did you mean to reopen this?

Comment 16 Steffen Pingel

2011-06-13 13:45:44 EDT

Reopening as a reminder.

Comment 17 Steffen Pingel

2012-03-07 06:13:52 EST

I have re-committed the changes.