Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348348

Summary: focus filter sticks when FocusTaskList action runs twice
Product: z_Archived Reporter: Steffen Pingel <steffen.pingel>
Component: MylynAssignee: Steffen Pingel <steffen.pingel>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: greensopinion, shawn.minto
Version: unspecified   
Target Milestone: 3.6   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 339777    
Bug Blocks:    
Attachments:
Description Flags
fix
none
mylyn/context/zip none

Description Steffen Pingel CLA 2011-06-05 18:01:42 EDT
This problem was introduced by the changes made for bug 339777. TaskListFocusAction can get into a state when uninstallInterestFilter() does not remove the interest filter resulting in a Task List that is always focused.
Comment 1 Steffen Pingel CLA 2011-06-06 11:08:44 EDT
Created attachment 197406 [details]
fix
Comment 2 Steffen Pingel CLA 2011-06-06 11:08:47 EDT
Created attachment 197407 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2011-06-06 11:10:39 EDT
Steps:
1. Focus Task List
2. Activate Task that has a stack trace
3. Unfocus Task List

The focus filter is still active even though the task list is unfocused. This is due to the viewer initialization in ContextPopulationStrategy.populateContext() which causes FocusTaskListAction.installInterestFilter() to get invoked twice which causes the interest filter to get added to previousFilters and previousSorter to get set to an unexpected sorter.
Comment 4 Steffen Pingel CLA 2011-06-06 11:31:56 EDT
Fix applied to head and e_3_7_m_3_6_x branch.