Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348331

Summary: [Contributions] [Dialogs] Customize Perspective dialog - disabled/unavailable tree item labels not visible
Product: [Eclipse Project] Platform Reporter: Stanimir Stamenkov <stanio>
Component: UIAssignee: Noopur Gupta <noopur_gupta>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, loskutov, noopur_gupta
Version: 3.7   
Target Milestone: 4.5 M6   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/41411
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f71f5cf8c055840273a521aef0d3ea3ea333196e
https://git.eclipse.org/r/45844
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c66798772756e5fd50c706b6ee8618418f7fa3c6
Whiteboard:
Bug Depends on:    
Bug Blocks: 420956    
Attachments:
Description Flags
Screenshot demonstrating the problem
none
Screenshot with fix
none
Colors on Fedora GTK2/KDE (OK) none

Description Stanimir Stamenkov CLA 2011-06-05 10:44:07 EDT 
Build Identifier: Eclipse Platform Version: 3.7.0 Build id: I20110603-0909

The disabled/unavailable tree item labels on the Tool Bar Visibility and Menu Visibility tabs in the Customize Perspective dialog are not visible given the color scheme uses gray background for input components, instead of the common default of white.

Reproducible: Always

Steps to Reproduce:
1. Set a Windows Classic theme with a gray (red: 192, green: 192, blue: 192) Window background color;
2. Start Eclipse and open Window -> Customize Perspective dialog;
3. Observe the disabled/unavailable tree items on the Tool Bar Visibility tab.
Comment 1 Stanimir Stamenkov CLA 2011-06-05 10:49:38 EDT 
Created attachment 197360 [details]
Screenshot demonstrating the problem
Comment 2 Stanimir Stamenkov CLA 2011-06-05 10:51:52 EDT 
I guess the color used should not be fixed like that, but should be the one configured for disabled items.
Comment 3 Andrey Loskutov CLA 2015-02-07 17:57:46 EST 
Stanimir, if you still care - can you please check with Eclipse 4.5 M5? I do not have access to Windows, on Linux it looks OK.
Comment 4 Noopur Gupta CLA 2015-02-09 06:06:43 EST 
Created attachment 250614 [details]
Screenshot with fix

(In reply to Andrey Loskutov from comment #3)
> Stanimir, if you still care - can you please check with Eclipse 4.5 M5? I do
> not have access to Windows, on Linux it looks OK.

I can still see the issue with 4.5 M5 on Windows Classic theme and Gray Window background color.

We can use SWT.COLOR_WIDGET_NORMAL_SHADOW instead of SWT.COLOR_GRAY, which is also used in many other implementations of IColorProvider#getForeground to show disabled/deleted items' text. 

Proposed fix: https://git.eclipse.org/r/#/c/41411/

Attached screenshots of CPD on Windows 7 and Windows Classic (with Gray background) themes with the fix.

Andrey, please check if it still looks OK on Linux with the fix.
Comment 5 Eclipse Genie CLA 2015-02-09 08:42:32 EST 
New Gerrit change created: https://git.eclipse.org/r/41411
Comment 6 Andrey Loskutov CLA 2015-02-10 15:24:37 EST 
Created attachment 250692 [details]
Colors on Fedora GTK2/KDE (OK)

(In reply to Noopur Gupta from comment #4)
> Proposed fix: https://git.eclipse.org/r/#/c/41411/
> Andrey, please check if it still looks OK on Linux with the fix.

"Linux" is a very broad definition, additionally it heavily depends on a GTK theme. On my Fedora 21 box, under GTK2/KDE and QtCurve theme it looks fine (as before), see screenshot.
Comment 8 Dani Megert CLA 2015-02-19 10:03:19 EST 
.
Comment 9 Eclipse Genie CLA 2015-04-15 04:15:26 EDT 
New Gerrit change created: https://git.eclipse.org/r/45844