Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348297

Summary:	Installation of M1 build shows 2 "EDT Feature" features / need clearer names
Product:	z_Archived	Reporter:	Will Smythe <smythew>
Component:	EDT	Assignee:	Matt Heitz <mheitz>
Status:	CLOSED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	lasher, mheitz
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Will Smythe

2011-06-03 22:23:55 EDT

Build Identifier: 070 M1

See attached screen shot. Users will not know what the difference is (is there a difference?).

Also, we should update the names in general and follow any Eclipse naming practices. For example, do feature names typically include "Feature" in the name, or is this normally left off? We should look around and see what others are doing.

Reproducible: Always

Comment 1 Matt Heitz

2011-06-04 09:10:57 EDT

I noticed that too.  The second one is from the feature containing our source code, which is automatically created during the build.  Looks like it uses the same name as the feature where its contents came from.  I'll see if I can change that.

Comment 2 Matt Heitz

2011-06-08 09:23:22 EDT

Fixed in the 5/8 build.

The three features are now named: EGL Development Tools (EDT) SDK Feature, EGL Development Tools (EDT) Source Code Feature, and EGL Development Tools (EDT) Feature.

Right now all three need to be (un)installed together.  In the future I want them to be grouped, a parent and two children, so no one can be stuck with only part of EDT.

Comment 3 Matt Heitz

2011-06-08 09:26:15 EDT

I opened a new enhancement for the change described in the previous comment.
Bug 348732 - Have only one EDT feature, or a hierarchy

Comment 4 Matt Heitz

2011-06-08 13:33:48 EDT

Fixed.

Comment 5 Matt Heitz

2011-06-08 13:35:38 EDT

Meant to close this when I added the "Fixed" comment.

Comment 6 Will Smythe

2011-06-09 08:46:13 EDT

Matt - if you look at the list of Eclipse features (Help > About > Install Details), other Eclipse feature names do not have "Feature" at the end. Please make sure our names are consistent.

Also, can you ensure the Provider name is set appropriately?. To be consistent, ours would need to be "Eclipse EGL Development Tools"

One last thing - I don't actually see the EDT features on this dialog (Help>About>Install Details), even though EDT is installed.

Comment 7 Matt Heitz

2011-06-09 12:03:38 EDT

Will,

I put "Feature" on the end of the names because some Eclipse features do that...but it's not done consistently and I like your way better, so I've changed it.

I also updated the Provider of all of our plugins and features as you suggested, and I made sure their names were meaningful and consistent with each other.

I opened bug 348924 for the EDT features not showing up in Eclipse's Installation Details dialog.

-Matt

Comment 8 Lisa Lasher

2011-08-26 18:06:36 EDT

changing to Enhancement, as this isn't really a defect.

Comment 9 Lisa Lasher

2011-11-04 11:42:39 EDT

Closing this work item