Bug 348260

Comment 1 Sami Wagiaalla 2011-06-03 16:15:59 EDT

Created attachment 197335 [details]
Add Autotools shared library template

Comment 2 Andrew Overholt 2011-06-03 16:36:58 EDT

Should autotools/org.eclipse.linuxtools.cdt.autotools.ui/templates/projecttemplates/AutotoolsSharedLibraryProject/template.properties really be Copyright IBM?

I won't speak to the rest of the template but I like the contribution.  Thanks!

Comment 3 Sami Wagiaalla 2011-06-06 10:42:30 EDT

Created attachment 197398 [details]
Add Autotools shared library template

Corrected copyright notice for AutotoolsSharedLibraryProject/template.properties, and did the same for AutotoolsSharedLibraryProject/template.xml and other minor fixes.

Thanks for the review

Comment 4 Jeff Johnston 2011-06-06 16:13:18 EDT

Comment on attachment 197398 [details]
Add Autotools shared library template

ChangeLog file is missing so template does not work.

To execute sample program, I had to add LD_LIBRARY_PATH to point to the secret .libs directory.  It would be nice if this could be set up automatically for the project or at worst case, documented in the sample program source.

Comment 5 Sami Wagiaalla 2011-06-07 13:52:32 EDT

Created attachment 197527 [details]
Add Autotools shared library template

- Add comment explaining how to run the uninstalled executable
- Add missing Changelog file to the template

Comment 6 Jeff Johnston 2011-06-08 17:15:43 EDT

Comment on attachment 197527 [details]
Add Autotools shared library template

I take it there was no way to handle the output script name or have it runnable directly from Eclipse.

Minor comments:

You have "smaple" specified.

Not sure about what you meant to say with:
"User the name of the executable
+# with each non alpha-numeric character is eplaced by '_'"

Comment 7 Sami Wagiaalla 2011-06-09 16:10:45 EDT

Created attachment 197729 [details]
Add Autotools shared library template

- Spelling, grammar and punctuation fixes.
- Clarified comments where clarification was requested. 

Thanks for the review Jeff

Comment 8 Jeff Johnston 2011-06-10 14:48:30 EDT

Comment on attachment 197729 [details]
Add Autotools shared library template

Looks good.  Thanks.

Comment 9 Andrew Overholt 2011-06-10 15:20:50 EDT

Will you open a CQ for this and bug 348432's contributions, Jeff?

Comment 10 Jeff Johnston 2011-06-10 17:20:04 EDT

(In reply to comment #9)
> Will you open a CQ for this and bug 348432's contributions, Jeff?

Yes, a CQ has been opened: http://dev.eclipse.org/ipzilla/show_bug.cgi?id=5282

When this is approved, I will commit the patch to the repository.

Comment 11 Jeff Johnston 2011-06-16 17:35:44 EDT

Code checked into repository.  Thanks.