Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348153

Summary:	Commit amend ignores existing change-id from previous commit
Product:	[Technology] EGit	Reporter:	Matthias Sohn <matthias.sohn>
Component:	UI	Assignee:	Matthias Sohn <matthias.sohn>
Status:	CLOSED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	dariusz.luksza, jens.baumgart, stefan.lay
Version:	1.0
Target Milestone:	1.0.0
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Matthias Sohn

2011-06-02 19:31:26 EDT

used EGit 1.0.0.201106011211-rc3	and 3.6 SR2 SDK

- start from a project with at least one commit containing a Gerrit change-id
- modify a file which is already in the repository
- Team > Commit, click "Amend"
- the commit dialog generates a fresh change-id template (I0000..), instead it should leave the existing change-id from the commit to be amended untouched.

the following scenario works as expected:
- start from a commit containing a change-id
- from clean working tree click Team > Commit
- accept to amend, this time the old change-id remains untouched

Comment 1 Stefan Lay

2011-06-03 06:33:23 EDT

This bug was introduced by 4347a21fa0e7c1979839ea4fb7.

I can reproduce it on Windows 7.

Comment 2 Dariusz Luksza

2011-06-04 20:09:13 EDT

Fix merged as commit 29f005e40ff25bf6d53f76d31e18018762c4c0f8

Comment 3 Dariusz Luksza

2011-06-04 20:09:39 EDT

Fix merged as commit 29f005e40ff25bf6d53f76d31e18018762c4c0f8