Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348139

Summary: http://orion.eclipse.org/sites/site.html broken
Product: [ECD] Orion Reporter: Boris Bokowski <bokowski>
Component: ClientAssignee: Project Inbox <e4.orion-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: aniefer, mamacdon, simon_kaegi
Version: 0.2   
Target Milestone: 0.2   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Boris Bokowski CLA 2011-06-02 16:17:32 EDT 
on orion.eclipse.org:

Uncaught Error: require: module name 'i18n!dijit/nls/loading' has not been loaded yet for context: _
Uncaught Error: require.js load timeout for modules: built-site
Comment 1 Andrew Niefer CLA 2011-06-02 17:41:04 EDT 
I think 'dijit' needs to be added to the list of requirements in the define at the top of site.js, there are a couple of references to dijit.byId.

Someone else can make this change, I'm leaving soon so won't "release and run"
Comment 2 John Arthorne CLA 2011-06-02 22:07:08 EDT 
I'm not sure it's that simple. I see other pages such as list.js making use of dijit without requiring it directly. I'll wait for Simon or Mark to take a look rather than blindly making a change.
Comment 3 Susan McCourt CLA 2011-06-02 22:14:40 EDT 
(In reply to comment #2)
> I'm not sure it's that simple. I see other pages such as list.js making use of
> dijit without requiring it directly. I'll wait for Simon or Mark to take a look
> rather than blindly making a change.

Yeah, I think it's unrelated to the problem reported.

But...I do think that those files (such as list.js) using dijit.byId should be declaring a dependency on dijit. They are getting away with not doing so because they have some other dependency (orion/widgets/RegistryTree) which itself requires dijit.  But it should probably be made explicit.
Comment 4 Mark Macdonald CLA 2011-06-02 22:25:08 EDT 
The error appears to be from the 
 
> dojo.requireLocalization("dijit", "loading");

call in _Grid.js. If I it to a requirejs-style load instead (ie. add "i18n!dijit/nls/loading" to the required modules), the page loads OK.
Comment 5 Simon Kaegi CLA 2011-06-02 22:41:07 EDT 
We really should be making sure to properly "require" dijit where we use it, it will work in some cases for now because dojo, dijit, and dojox are global symbols but that may change in Dojo 1.7.

Mark is right. We need to add the dependency. i18n dependencies are a bit of a pain clearly...