Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348131

Summary:

In the p2 console, the flavor is not considered in provaddprofile

Product:

[Eclipse Project] Equinox

Reporter:

Anthony Dahanne <anthony.dahanne>

Component:

Assignee:

P2 Inbox <equinox.p2-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

pascal, sebastien.angers

Version:

unspecified

Target Milestone:

Juno M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
removes the requirement on flavor, indicates in the help message the possibility to specify environments	pascal: iplog+

Description Anthony Dahanne

2011-06-02 15:44:10 EDT

Build Identifier: equinox/p2 trunk

The method in charge of adding a new profile, through the p2 console, in org.eclipse.equinox.internal.p2.console.ProvCommandProvider, named _provaddprofile ; required a flavor to be specified;
String flavor = interpreter.nextArgument();
		if (profileId == null || location == null || flavor == null) {
			interpreter.println("Id, location, and flavor must be provided");
			return;
		}

 but does not use it.
Worse, just after this, we read a 4th argument, environments, that could be used; but since the user is supposed to enter only 3 arguments, it's not used neither.


I think it would be good to remove the requirement on flavor and tell in the help message that the 3rd optional argument is environments 
I coudl

Reproducible: Always

Comment 1 Anthony Dahanne

2011-06-02 15:45:50 EDT

Created attachment 197265 [details]
removes the requirement on flavor, indicates in the help message the possibility to specify environments

Comment 2 Pascal Rapicault

2011-06-07 21:40:01 EDT

Patch applied thx.

Comment 3 Anthony Dahanne

2011-06-07 22:19:35 EDT

thanks !