Bugzilla – Full Text Bug Listing
| Summary: | Eliminate compiler warnings | ||
|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Rüdiger Herrmann <ruediger.herrmann> |
| Component: | RWT | Assignee: | Project Inbox <rap-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | ||
| Version: | unspecified | ||
| Target Milestone: | 1.5 M1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
Resolved the majority of compiler warnings by adding type parameters. To be as least intrusive as possible, compiler warnings in 'foreign' code (SWT, Yahoo compressor, CSS parser, etc.) were suppressed by annotating the whole class with @SuppressWarnings("all").
The following classes were left unchanged intentionally:
* EncodungUtil in order to not disturb the changes for bug 346123.
* DisposedWidgets as I think this information should be held in IDisplayAdapter (see bug 348138)
* ThemeStoreWriter and PropertyResolver: too many raw Maps are passed around to keep oversight
Changes are in CVS HEAD
|
The number of compiler warnings in org.eclipe.rap.rwt and ...q07 increased again since we changed the execution environment to Java 1.5. But with Java 1.5 we are now able to suppress warnings. In source code that we copied as-is from SWT, a frequent warning is for assigning parameters. There is no distinct @SuppressWarning for this type of warning. Therefore, I suggest to annotate SWT code with @SuppressWarnings("all") at class level. Warnings new in Java 1.5 (missing generic type parameters mostly) should be fixed in that the code is adjusted to not produce warnings any more.