Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348030

Summary: Provide some hints in order to be able to determine cause of opaque bugs
Product: z_Archived Reporter: Severin Gehwolf <sgehwolf>
Component: LinuxToolsAssignee: Severin Gehwolf <sgehwolf>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: kksebasti, linux.oprofile-inbox, overholt
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Proposed patch
none
Print more verbose messages if debugging is turned on. sgehwolf: review?

Description Severin Gehwolf CLA 2011-06-01 18:18:14 EDT
Created attachment 197186 [details]
Proposed patch

When calling out to opcontrol it's a good idea to print what's going on on stderr/stdout of the sub-process. It may provide hints as to what is *really* going wrong.

Andrew, could you have a look?
Comment 1 Andrew Overholt CLA 2011-06-01 19:17:23 EDT
I like the intent.  Can we put it in some sort of -debug output that is controlled with a .options file like the p2 diagnostics?
Comment 2 Severin Gehwolf CLA 2011-06-02 10:53:39 EDT
Created attachment 197234 [details]
Print more verbose messages if debugging is turned on.

Thanks, Andrew. How about this? Now, it only prints those messages if eclipse is started with -debug and some .options file (either in $(pwd)/.options or $HOME/.options) has:

org.eclipse.linuxtools.oprofile.core/debug

in it.
Comment 3 Andrew Overholt CLA 2011-06-02 11:13:08 EDT
It looks good!  +1 to commit now as it will help us sort out OProfile issues.
Comment 4 Severin Gehwolf CLA 2011-06-02 15:11:58 EDT
Thanks Andrew!

Pushed: 34770cc454334dd8d600690417f9a18f46aed97c