Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 348000

Summary: [TMF] Filter viewer does not update with new custom parser fields
Product: z_Archived Reporter: Patrick Tasse <patrick.tasse>
Component: LinuxToolsAssignee: Francois Chouinard <fchouinard>
Status: CLOSED FIXED QA Contact: Francois Chouinard <fchouinard>
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 301610    
Attachments:
Description Flags
Proposed patch in org.eclipse.linuxtools.tmf.ui package jjohnstn: iplog+

Description Patrick Tasse CLA 2011-06-01 15:25:58 EDT
Build Identifier: 

Submitting a patch to fix a problem with the filter viewer.

When the custom parser wizard is used to create a new custom parser or edit the field labels of a custom parser, the applied changes are not reflected in the filter viewer.

Since the filter viewer compiles the list of field labels and event types at class loading and stores them in static variables, any changes made by the user to the custom parsers will not be available until the workbench is restarted.

The solution is to regenerate those lists every time in the constructor of the filter node composite. They will then reflect the latest changes made by the user.

Reproducible: Always

Steps to Reproduce:
1. Open the Filters view to set the labels and event types.
2. Create a new custom parser from the Manage Custom Parsers dialog.
3. Add at least one group (Text) or element (XML) in the custom parser.
4. Create a new filter in the Filters view or the Colors view.
5. Add a node to the filter which contains a "field" parameter.
6. Verify that the new custom parser field is available in the combo button.
7. Add an "event type" node to the filter.
8. Verify that the new custom parser type is available in the combo button.
Comment 1 Patrick Tasse CLA 2011-06-01 15:27:18 EDT
Created attachment 197154 [details]
Proposed patch in org.eclipse.linuxtools.tmf.ui package

Legal Message: I, Patrick Tasse, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer to make this contribution under
the EPL.
Comment 2 Patrick Tasse CLA 2012-09-06 17:55:36 EDT
This change was committed and delivered in 0.10.0.