Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347990

Summary: [TMF] Incorrect handling of preview table in custom parser wizards
Product: z_Archived Reporter: Patrick Tasse <patrick.tasse>
Component: LinuxToolsAssignee: Francois Chouinard <fchouinard>
Status: CLOSED FIXED QA Contact: Francois Chouinard <fchouinard>
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 301610    
Attachments:
Description Flags
Proposed patch in org.eclipse.linuxtools.tmf.ui package none

Description Patrick Tasse CLA 2011-06-01 14:22:06 EDT 
Build Identifier: 

Submitting a patch to correct the handling of the preview table in the custom parser wizards (Text and XML).

The second page of the wizard contains a preview table. The number of items in the table is arbitrarily set to 50, to limit the number of rows in the preview table. In earlier code this worked correctly, but in the latest code, if the parsed preview text contains less than 50 events, the table keeps trying to fetch the row data, in some case resulting in "too many files open" exceptions.

The solution is simply to remove the brute force setting of the number of items in the table. The trace indexing is automatically triggered in the trace constructor and this will fill the table properly. The number of parsed events in the preview table is no longer limited.

Reproducible: Always

Steps to Reproduce:
1. Open the Manage Custom Parsers dialog in the TMF > Projects view.
2. Click New... to open the wizard.
3. Fill the first page with enough data to be able to click Next...
4. In the second page click Finish
Comment 1 Patrick Tasse CLA 2011-06-01 14:23:23 EDT 
Created attachment 197131 [details]
Proposed patch in org.eclipse.linuxtools.tmf.ui package

Legal Message: I, Patrick Tasse, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer to make this contribution under
the EPL.
Comment 2 Patrick Tasse CLA 2012-09-06 18:00:54 EDT 
This change was committed with bug 353020 and delivered in 0.9.0.
Comment 3 Jeff Johnston CLA 2012-09-28 13:42:29 EDT 
Comment on attachment 197131 [details]
Proposed patch in org.eclipse.linuxtools.tmf.ui package

Functionality applied in another bug.