Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347983

Summary: [UI] Splitting a DW no longer works
Product: [Eclipse Project] e4 Reporter: Eric Moffatt <emoffatt>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: VERIFIED FIXED QA Contact: Eric Moffatt <emoffatt>
Severity: major    
Priority: P3 CC: pwebster, remy.suen
Version: unspecifiedFlags: remy.suen: review+
Target Milestone: 4.1 RC4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Disable the 'outerDock' behavior if the stack is not under an MArea or MPerspective none

Description Eric Moffatt CLA 2011-06-01 13:57:10 EDT 
This was introduced during the changes for bug 341009. The code to detect an 'outerDock' should only be used if the given 'dropStack' is inside either an MArea or MPerspective...
Comment 1 Eric Moffatt CLA 2011-06-01 13:58:30 EDT 
Created attachment 197122 [details]
Disable the 'outerDock' behavior if the stack is not under an MArea or MPerspective
Comment 2 Eric Moffatt CLA 2011-06-01 14:00:29 EDT 
Remy, can you please review the patch ?
Comment 3 Eric Moffatt CLA 2011-06-01 14:21:00 EDT 
*** Bug 347561 has been marked as a duplicate of this bug. ***
Comment 4 Remy Suen CLA 2011-06-01 14:37:06 EDT 
(In reply to comment #1)
> Created attachment 197122 [details]
> Disable the 'outerDock' behavior if the stack is not under an MArea or
> MPerspective

Looks okay to me.

Please open a new bug so that the "outer dock" behaviour is enabled and brought back for detached windows in 4.2.
Comment 5 Eric Moffatt CLA 2011-06-01 15:09:47 EDT 
Committed in >20110601. Applied the patch.
Comment 6 Paul Webster CLA 2011-06-02 12:36:40 EDT 
bug 348078 might be related to this.  To confirm.

PW
Comment 7 Eric Moffatt CLA 2011-06-06 09:52:28 EDT 
Verified in I20110604-2201.