Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347940

Summary: [Compatibility] Timer execs greatly affect XWindow based systems
Product: [Eclipse Project] e4 Reporter: Eric Moffatt <emoffatt>
Component: UIAssignee: Eric Moffatt <emoffatt>
Status: VERIFIED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: carolynmacleod4, pwebster, remy.suen
Version: unspecifiedFlags: emoffatt: review?
Target Milestone: 4.1 RC4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Gather up all the items to be checked rather than spawning a new timerExec for each one none

Description Eric Moffatt CLA 2011-06-01 09:38:28 EDT 
While Car was testing 4.1 on the various platforms she noticed that the performance was *very* bad (about 1 character per sec typing in an editor).

We tracked this down to the use of multiple timerExec's used to keep the various toolbars enablement state up to date...
Comment 1 Eric Moffatt CLA 2011-06-01 11:14:00 EDT 
Created attachment 197100 [details]
Gather up all the items to be checked rather than spawning a new timerExec for each one
Comment 2 Eric Moffatt CLA 2011-06-01 11:15:36 EDT 
Paul, please review the patch...
Comment 3 Paul Webster CLA 2011-06-01 12:02:22 EDT 
I've only made one slight change.  The HCI can create one instance of the safe runnable, instead of one per call, since it contains no state and doesn't change.

Committed to HEAD.  Remy, could you also have a quick look at what I've committed as a confirmation?


PW
Comment 4 Remy Suen CLA 2011-06-01 12:30:46 EDT 
(In reply to comment #3)
> Committed to HEAD.  Remy, could you also have a quick look at what I've
> committed as a confirmation?

Looks okay to me.
Comment 5 Eric Moffatt CLA 2011-06-01 13:53:20 EDT 
Marking as FIXED.
Comment 6 Eric Moffatt CLA 2011-06-06 09:49:48 EDT 
Verified in I20110604-2201.