Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347833

Summary: Wrong plug-in providers and missing incubation tags.
Product: [Modeling] MoDisco Reporter: Gregoire Dupe <gdupe>
Component: MainAssignee: Gregoire Dupe <gdupe>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: hugo.bruneliere, Kenn.Hussey, modisco.web-inbox, nicolas.bros
Version: 0.9.0Flags: nicolas.bros: indigo+
Kenn.Hussey: pmc_approved+
hugo.bruneliere: review+
nicolas.bros: review+
Target Milestone: 0.9.0 RC3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch fixing Bundle-Name and Bundle-Vendor
nicolas.bros: iplog+
Non-regression test nicolas.bros: iplog+

Description Gregoire Dupe CLA 2011-05-31 13:28:52 EDT 
Hello,

The following plug-ins do not have the right provider name:
 - org.eclipse.gmt.modisco.infra.prefuse
 - org.eclipse.modisco.infra.discovery
 - org.eclipse.modisco.java.discoverer.ui

The following plug-ins do not have the "(Incubation)" tag in them name:
 - org.eclipse.gmt.modisco.infra.prefuse
 - org.eclipse.modisco.infra.discovery 
 - org.eclipse.modisco.java.composition.discoverer.ui
 - org.eclipse.modisco.java.discoverer.ui
 - org.eclipse.modisco.jee.jsp.discoverer.ui
 - org.eclipse.modisco.kdm.source.discoverer
 - org.eclipse.modisco.kdm.source.discoverer.ui
 - org.eclipse.modisco.kdm.uml2converter.ui

Regards,
Gregoire
Comment 1 Gregoire Dupe CLA 2011-05-31 14:39:53 EDT 
Created attachment 197025 [details]
Patch fixing Bundle-Name and Bundle-Vendor
Comment 2 Gregoire Dupe CLA 2011-05-31 14:40:59 EDT 
Created attachment 197026 [details]
Non-regression test

Here is a non-regression test to avoid plug-in names and provider names problems.
Comment 3 Gregoire Dupe CLA 2011-05-31 14:44:05 EDT 
Hello Kenn, Nicolas and Hugo,

I hope the fix can be committed before MoDisco RC3 (tomorrow).

Do you agree with my patches ?

Regards,
Gregoire Dupe
Comment 4 Hugo Bruneliere CLA 2011-06-01 04:08:05 EDT 
(In reply to comment #3)
> Hello Kenn, Nicolas and Hugo,
> 
> I hope the fix can be committed before MoDisco RC3 (tomorrow).
> 
> Do you agree with my patches ?
> 
> Regards,
> Gregoire Dupe

Hello Greg,

That's OK for me.
You can go on with the patches.

Regards,

Hugo
Comment 5 Nicolas Bros CLA 2011-06-01 04:42:03 EDT 
Hi Gregoire,

Since you're having trouble committing, I committed your first patch in revision 4447, and the patch for tests in revision 4448.
Comment 6 Hugo Bruneliere CLA 2011-06-01 04:49:35 EDT 
(In reply to comment #5)
> Hi Gregoire,
> 
> Since you're having trouble committing, I committed your first patch in
> revision 4447, and the patch for tests in revision 4448.

Thanks Nicolas!
Comment 7 Gregoire Dupe CLA 2011-06-17 09:46:28 EDT 
The plug-ins have been fixed in the version 0.9.0.v201106080847.

This bug can be closed.
Comment 8 Hugo Bruneliere CLA 2011-08-18 08:30:22 EDT 
Bug solved.