Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347830

Summary: Syntax error in compare-feature.js
Product: [ECD] Orion Reporter: John Arthorne <john.arthorne>
Component: ClientAssignee: libing wang <libingw>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: simon_kaegi
Version: 0.2   
Target Milestone: 0.2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description John Arthorne CLA 2011-05-31 12:54:48 EDT
Line 41 of compare-feature.js is:

var editorParentDiv = new dijit.layout.ContentPane({class:"paneScrolled" ,id :editorParentDivId ,region: "center", style:"width:100%;height: 100%;overflow: hidden;"});

However "class" is a reserved word in JavaScript. Trying to parse this file with Rhino I get:

js: "C:\1target\eclipseweb\org.eclipse.orion.client\bundles\org.eclipse.orion.client.core\static\js\compare\compare-features.js", line 41: invalid property id
js:                     var editorParentDiv = new dijit.layout.ContentPane({class:"paneScrolled" ,id :editorParentDivId ,region: "center", style:"width:100%;height: 100%;overflow: hidden;"});
js: ............................................................^
org.mozilla.javascript.EvaluatorException: Compilation produced 1 syntax errors.
Comment 1 John Arthorne CLA 2011-05-31 12:55:26 EDT
Note I haven't seen any browsers complain about this, but perhaps Rhino is just being more strict.
Comment 2 libing wang CLA 2011-06-09 15:14:04 EDT
fixed with commit 8cf0a6b8d938f2d8c95f3281c6c90b862eb147df
Author: Libing Wang <libingw@ca.ibm.com> 2011-06-02 13:10:51
Committer: Libing Wang <libingw@ca.ibm.com> 2011-06-02 13:10:51