Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347712

Summary: Use shared AST in ExtractLocalVariableRefactoring
Product: [Tools] CDT Reporter: Sergey Prigogin <eclipse.sprigogin>
Component: cdt-refactoringAssignee: Sergey Prigogin <eclipse.sprigogin>
Status: RESOLVED FIXED QA Contact: Sergey Prigogin <eclipse.sprigogin>
Severity: normal    
Priority: P3 CC: cdtdoug, eostroukhov, malaperle, waste.manager
Version: 8.0   
Target Milestone: 8.1.0   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 347599    
Bug Blocks: 255092    
Attachments:
Description Flags
Proposed fix eclipse.sprigogin: iplog-

Description Sergey Prigogin CLA 2011-05-30 20:37:11 EDT 
Move ExtractLocalVariableRefactoring to the new framework that allows for use of shared AST and doesn't require dirty editors to be saved prior to refactoring.
Comment 1 Sergey Prigogin CLA 2011-05-30 21:10:09 EDT 
Created attachment 196950 [details]
Proposed fix
Comment 2 Marc-André Laperle CLA 2011-05-31 00:47:04 EDT 
*** Bug 339636 has been marked as a duplicate of this bug. ***
Comment 3 Marc-André Laperle CLA 2012-02-01 02:44:32 EST 
Hi Sergey, I was starting to look at using shared AST in Extract Constant so I looked at this patch for reference. It looks like it needs to be updated because bug 347599 added a different API. Are you planning to update it soon or should I go ahead and update it? It would be great to have all the refactorings updated with the shared AST for Juno!
Comment 4 Sergey Prigogin CLA 2012-02-01 10:14:47 EST 
(In reply to comment #3)
I plan to do it in a week or two, once I finish a face lift of Extract Function.
Comment 5 Sergey Prigogin CLA 2012-02-15 18:46:42 EST 
Fixed in master. CDT now requires platform 3.8+.
Comment 6 CDT Genie CLA 2012-02-29 13:25:42 EST 
*** cdt git genie on behalf of Sergey Prigogin ***

    Bug 347712 - Use shared AST in ExtractLocalVariableRefactoring.

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=3453fa6fcd43800486c8d8c95e429f49d4121459