Bugzilla – Full Text Bug Listing
| Summary: | Create Patch misses some of the selected files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> | ||||||
| Component: | CVS | Assignee: | Malgorzata Janczarska <malgorzata.tomczyk> | ||||||
| Status: | RESOLVED WORKSFORME | QA Contact: | |||||||
| Severity: | major | ||||||||
| Priority: | P3 | CC: | malgorzata.tomczyk, pwebster, Szymon.Brandys, tomasz.zarna | ||||||
| Version: | 3.7 | ||||||||
| Target Milestone: | 3.8 M7 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Markus Keller
I followed your steps and failed to reproduce this bug. Maybe it's another incarnation of Bug 201714 or Bug 294650. Can you tell me witch build version are you using? Could you check two things on opened patch wizard before the wrong patch is generated: 1. Expand all tree nodes and verify if both files were added to the tree 2. Check if before clicking "Finish" all nodes are selected 3. If not all nodes are selected click "Select All" and tell me if it selected all the nodes. > Can you tell me witch build version are you using? See first line of comment 0. I can still reproduce consistently with I20110603-0909. Note that the bug only happens the first time after a restart. When I create the patch a second time, both files are correctly included. > Could you check two things on opened patch wizard before the wrong patch is > generated: > 1. Expand all tree nodes and verify if both files were added to the tree Yes, both files are there (plus the irrelevant change set). > 2. Check if before clicking "Finish" all nodes are selected Yes, all nodes are selected. Clicking "Finish" now (after expanding all nodes) generates the correct patch. So the expansion of the nodes already fixes the problem. > 3. If not all nodes are selected click "Select All" and tell me if it selected > all the nodes. "Select All" alone does not help (patch still incomplete, unless I expand the nodes). To rule out other influences (background updates...), please close all editors and the Synchronize view before you restart. Created attachment 212733 [details] Hack for testing - do not commit Mark, I tried again to reproduce this bug according to your scenario. I tried exactly what you described as well as with some variations. I am still unable to reproduce it. Maybe you have a workspace that has this problem and you could attach? This would rule out any other setting that we may have different. In meanwhile I looked into the code and I found that there where some timing issues addressed in bug 201714. Maybe in case of your workspace this fix was not sufficient. Would you be able to apply this patch to org.eclipse.team.core and see if you still observe the problem? Created attachment 213020 [details]
workspace
I could still reproduce with I20110613-1736 (3.7), but with I20120320-1400 (a 3.8 build), it works fine.
I don't want to invest more time into this. OK to close from my side.
(In reply to comment #4) > I could still reproduce with I20110613-1736 (3.7), but with I20120320-1400 (a > 3.8 build), it works fine. Closing the bug, as it seems to be already resolved. |