Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347591

Summary:

Missing property publishPackFileAsSiblings and mappings rules in the jetty-rt-bundles build

Product:

[Technology] Dash

Reporter:

Hugues Malphettes <hmalphettes>

Component:

Maven

Assignee:

Jesse McConnell <jesse.mcconnell>

Status:

CLOSED FIXED

QA Contact:

Severity:

critical

Priority:

CC:

d_a_carver, igor, jesse.mcconnell, kaloyan, overholt

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
example of the manual patching of an artifacts.xml file	none
Patch to insert the missing property and mapping rules	none
Updated patch. there were some mistakes in the rules's filters.	none

Description Hugues Malphettes

2011-05-29 21:56:13 EDT

Created attachment 196863 [details]
example of the manual patching of an artifacts.xml file

Using tycho-0.12.0 and the dash signing plugin, the artifacts.xml produced is lacking a few things:
- the property artifact repository property 'publishPackFileAsSiblings' is missing: <property name='publishPackFilesAsSiblings' value='true'/>

- Two mapping rules are missing:
<rule filter='(&amp; (classifier=osgi.bundle) (format=packed))' output='${repoUrl}/plugins/${id}_${version}.jar.pack.gz'/>
<rule filter='(&amp; (classifier=org.eclipse.update.feature) (format=packed))' output='${repoUrl}/features/${id}_${version}.jar.pack.gz'/>


Manually changing the file does fix the indigo aggregation job.

Note that the linuxtools's artifacts.jar here:
http://download.eclipse.org/technology/linuxtools/update-indigo/artifacts.jar
Is not affected by this issue.

Comment 1 Hugues Malphettes

2011-05-29 22:05:18 EDT

The 2 builds that use the dash signing plugin are affected:

jetty-rt-bundles:
------------------
svn co http://dev.eclipse.org/svnroot/rt/org.eclipse.jetty/eclipse/jetty-bundles/jetty-7/

The pom.xml file that uses the signing plugin:
http://dev.eclipse.org/svnroot/rt/org.eclipse.jetty/eclipse/jetty-bundles/jetty-7/jetty.bundles.repo/

The hudson job: https://hudson.eclipse.org/hudson/view/Jetty-RT/job/jetty-rt-bundles/

jetty-rt-products:
------------------
svn co http://dev.eclipse.org/svnroot/rt/org.eclipse.jetty/eclipse/jetty-rt-indigo/

The pom.xml file that uses the signing plugin:
http://dev.eclipse.org/svnroot/rt/org.eclipse.jetty/eclipse/jetty-rt-indigo/jetty-features/org.eclipse.jetty.product/pom.xml

The hudson job: https://hudson.eclipse.org/hudson/view/Jetty-RT/job/jetty-rt-products/

Comment 2 Hugues Malphettes

2011-05-29 22:11:27 EDT

I have reviewed the linuxtools repositories.
The repository that is contributed to indigo:
http://download.eclipse.org/technology/linuxtools/update-indigo
is most likely not using the dash signing plugin:
- The artifacts.jar does not contain a META-INF folder (it does with the dash signing plugin)
- The artifacts.xml is indented and the packed artifacts declarations are not at the end of the xml file.
- the mapping rules and publishPackFileAsSiblings are in place
- the build: http://download.eclipse.org/technology/linuxtools/updates-nightly/artifacts.jar looks like it went through the signing plugin and it has the same issues than the jetty build.

Comment 3 Andrew Overholt

2011-05-30 08:52:27 EDT

You are correct that the Linux Tools (note:  two words) RC2 contribution (what is in update-indigo) was signed manually.

What is in updates-nightly _does_ use the Dash signing plugin.

Comment 4 David Carver

2011-05-30 12:17:26 EDT

Please make sure to use version 1.0.1 of the eclipse-maven-signing-plugin, this contains recent fixes that address some issues that Linux Tools had with it.

Comment 5 Hugues Malphettes

2011-05-30 21:39:15 EDT

Created attachment 196954 [details]
Patch to insert the missing property and mapping rules

Comment 6 Hugues Malphettes

2011-06-01 06:23:04 EDT

Created attachment 197079 [details]
Updated patch. there were some mistakes in the rules's filters.

Also added the patch for bug 347594

Comment 7 Hugues Malphettes

2011-06-01 12:32:31 EDT

Made a 1.0.1.2-SNAPSHOT build with this patch, deployed it on

     <pluginRepository>
       <id>intalio-dash-signing-plugin</id>
       <url>http://intalio.org/public/maven2</url>
       <snapshots>
        <enabled>true</enabled>
       </snapshots>
       <releases>
        <enabled>true</enabled>
       </releases>
     </pluginRepository>

The resulting build is now contributed to 3.7-RC3 and the aggregator is fine with it.

Comment 8 Hugues Malphettes

2011-06-01 22:24:11 EDT

*** Bug 347667 has been marked as a duplicate of this bug. ***

Comment 9 Jesse McConnell

2011-08-01 12:33:50 EDT

applied, sorry it took so long, didn't even know the issue was open

Comment 10 Hugues Malphettes

2011-08-01 21:24:30 EDT

Jesse, let us know when the build is released and what is the version number to use.
At the moment the jetty bundles are still incorrect.
They used to work when the plugin was picked up from intalio.org.
But at the moment it picks it up else where and I did not take the time to investigate as I'd rather have a release build.

Comment 11 Jesse McConnell

2011-08-01 21:40:02 EDT

yes, having issues with getting a clean build with it still, though I am having issues with the antrun portion I use in the jetty-wtp build more then this plugin directly, for that 1.0.2.0-SNAPSHOT should be working with this patch applied.