Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347577

Summary:	Birt does not allow redundant Bookmarks
Product:	z_Archived	Reporter:	khalil <kdureidy>
Component:	BIRT	Assignee:	Birt-ReportEngine-inbox <Birt-ReportEngine-inbox>
Status:	RESOLVED INVALID	QA Contact:	Xiaoying Gu <bluesoldier>
Severity:	normal
Priority:	P3	CC:	bluesoldier, jouyang
Version:	2.6.2
Target Milestone:	3.7.0
Hardware:	PC
OS:	All
Whiteboard:

Description khalil

2011-05-29 07:36:47 EDT

I add a bookmark on the report Table-Details Row, but only the first row take the bookmark, and other rows have the bookmark recreated and has different bookmark value for each row.

Example:
Report that view 10 rows of data with bookmark sortableRow on the Table Detailed Row, each row must have the same bookmark.

But found that only the first row has the sortableRow bookmark when i generate HTML file, and the other 9 rows has auto generated bookmark 'AUTOGENBOOKMARK_9'

Having the same bookmark(ID) for all rows is very important especially when we apply a stylesheet on the report html based on the ID, or when we apply a script to sort rows based on the row ID.

Comment 1 Jun Ouyang

2011-05-29 23:16:21 EDT

Khalil,

Do you have other way to apply same style for different elements? e.g, by class name?

It's very important to create distinct ids for report items to support bookmarks and advance features like using script to manipulate report items in HTML.

Comment 2 khalil

2011-05-30 02:21:49 EDT

(In reply to comment #1)

The only way I have is to use the ID, not the class
I can set the ID by bookmark, but i can't set the class for the Table-Details rows 
. and also I use a script based on the ID's


but wouldn't it be better if you let the user choose whether to have distinct ID's or not? like in the previous versions of birt.  

what benefit would it make if the ID's for Table-Details rows are unpredictable?

Comment 3 Jun Ouyang

2011-05-30 02:45:31 EDT

Ok, let's add a new html render option to allow duplicate bookmarks.

Comment 4 khalil

2011-05-30 02:51:48 EDT

Jun,

Thanks, that would be great.

(In reply to comment #3)
> Ok, let's add a new html render option to allow duplicate bookmarks.

Comment 5 Jun Ouyang

2011-05-31 22:14:13 EDT

We need keep the ID unique among the whole document, it is a rule of XHTML/HTML5. For the user's scenario, he can use various method to define the style for the element, for example using the parent-child selector:

.table_id > row

-Wei Yan

Comment 6 Jun Ouyang

2011-06-02 03:18:18 EDT

See last comment.