Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347556

Summary: [catalog] Checkstyle and PMD
Product: z_Archived Reporter: benson margulies <bimargulies>
Component: m2eAssignee: Project Inbox <m2e.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: igor
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
proposed improvements to installation flow none

Description benson margulies CLA 2011-05-28 15:11:01 EDT 
This bz offers up two plugin mapping plugins that travel together in one update site.

1. 

name: Checkstyle M2E
summary: M2E support for the maven-checkstyle-plugin. 
description: applies configuration from the maven-checkstyle-plugin to the eclipse Checkstyle plugin. Disables execution of the maven-checkstyle-plugin within Eclipse in favor of the Eclipse plugin.


2.

name: PMD M2E
summary:  M2E support for the maven-pmd-plugin.
description: applies configuration from the maven-checkstyle-plugin to the eclipse Checkstyle plugin. Disables execution of the maven-checkstyle-plugin within Eclipse in favor of the Eclipse plugin.


License: AL 2.0.
Provider: Benson Margulies/Basis Technology Corp.

Update site:

http://bimargulies.github.com/m2e-code-quality/site/0.13/M/0.13.0.201105271713

(Note: I could use some help in learning how to publish a sequence of releases into the same URL)

Source:

git://github.com/bimargulies/m2e-code-quality (the 0.13 branch)
Comment 1 Igor Fedorenko CLA 2011-06-05 09:34:40 EDT 
m2e version was changed to 1.0.0 to signify graduation from Incubator. Can you update version range to [1.0.0,1.1.0) and provide new build repository?
Comment 2 benson margulies CLA 2011-06-05 13:43:25 EDT 
Where is your repo with the 1.0.0 components?
Comment 3 benson margulies CLA 2011-06-05 13:50:02 EDT 
Using the sonatype repo and the target platform for e36, I fail with:


[INFO] [Software being installed: com.basistech.m2e.code.quality.shared 0.13.0.qualifier, Missing requirement: com.basistech.m2e.code.quality.shared 0.13.0.qualifier requires 'bundle org.eclipse.m2e.jdt [1.0.0,1.1.0)' but it could not be found]
Comment 4 Igor Fedorenko CLA 2011-06-05 13:53:51 EDT 
Use http://download.eclipse.org/technology/m2e/milestones/1.0 . For future reference, m2e download area is documented in http://wiki.eclipse.org/M2E_updatesite_and_gittags (as announced in m2e-dev http://dev.eclipse.org/mhonarc/lists/m2e-dev/msg00507.html ;-) )
Comment 5 benson margulies CLA 2011-06-05 18:07:32 EDT 
New update site:

http://bimargulies.github.com/m2e-code-quality/site/1.0/
Comment 6 Igor Fedorenko CLA 2011-06-06 09:42:58 EDT 
I am getting the error below trying to install PMD integration. What is update site URL of net.sourceforge.pmd.eclipse.plugin ?



Cannot complete the install because one or more required items could not be found.
  Software being installed: PMD configuration plugin for M2Eclipse 1.0.0.201106051811 (com.basistech.m2e.code.quality.pmd.feature.feature.group 1.0.0.201106051811)
  Missing requirement: M2Eclipse Extension to support Eclipse PMD Configuration 1.0.0.201106051811 (com.basistech.m2e.code.quality.pmd 1.0.0.201106051811) requires 'bundle net.sourceforge.pmd.eclipse.plugin 3.2.6' but it could not be found
  Cannot satisfy dependency:
    From: PMD configuration plugin for M2Eclipse 1.0.0.201106051811 (com.basistech.m2e.code.quality.pmd.feature.feature.group 1.0.0.201106051811)
    To: com.basistech.m2e.code.quality.pmd [1.0.0.201106051811]
Comment 7 Igor Fedorenko CLA 2011-06-06 09:43:49 EDT 
Same question for checkstyle, what is their update site url?


Cannot complete the install because one or more required items could not be found.
  Software being installed: Checkstyle configuration plugin for M2Eclipse 1.0.0.201106051811 (com.basistech.m2e.code.quality.checkstyle.feature.feature.group 1.0.0.201106051811)
  Missing requirement: Checkstyle configuration plugin for M2Eclipse 1.0.0.201106051811 (com.basistech.m2e.code.quality.checkstyle.feature.feature.group 1.0.0.201106051811) requires 'net.sf.eclipsecs.core [5.2.0,6.0.0)' but it could not be found
Comment 8 benson margulies CLA 2011-06-06 11:11:24 EDT 
They don't have p2 sites.

http://eclipse-cs.sf.net/update/

http://pmd.sourceforge.net/eclipse

*I* made P2 mirrors to help me build with tycho:


        <repository>
            <id>cs</id>
            <layout>p2</layout>
            <url>http://bimargulies.github.com/m2e-code-quality/checkstyle-p2-repository</url>
        </repository>
        <repository>
            <id>pmd</id>
            <layout>p2</layout>
            <url>http://bimargulies.github.com/m2e-code-quality/pmd-p2-repository</url>
        </repository>
Comment 9 Igor Fedorenko CLA 2011-06-06 12:42:37 EDT 
Created attachment 197419 [details]
proposed improvements to installation flow

Attached a patch solves two problems

1. it was not possible to install m2e/checkstyle and m2e/pmd integration if eclipse checkstyle and pmd plugins were not already installed.

2. introduced dependencies on checkstyle and pmd features (as opposed to individual bundles). otherwise installation gui does not show the user licensing terms of checkstyle and pmd, which is one of Eclipse Foundation requirements (see Bug 346830)

Also, can you provide sample projects we can use to see m2e/checkstyle and m2e/pmd integration in action?
Comment 10 benson margulies CLA 2011-06-06 16:45:21 EDT 
OK, I pushed version 1.0.0.201106061641 to the same place.
Comment 11 Igor Fedorenko CLA 2011-06-07 22:34:18 EDT 
Updated m2e discovery catalog to include checkstyle and pmd integrations. Thank you.
Comment 12 Denis Roy CLA 2021-04-19 13:27:06 EDT 
Moved to https://github.com/eclipse-m2e/m2e-core/issues/