Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347507

Summary:	Libra bundles are missing legal files
Product:	z_Archived	Reporter:	Kaloyan Raev <kaloyan>
Component:	Libra	Assignee:	Project Inbox <libra.general-inbox>
Status:	CLOSED FIXED	QA Contact:	Kaloyan Raev <kaloyan>
Severity:	blocker
Priority:	P3	CC:	david_williams, neil.hauge
Version:	unspecified	Flags:	david_williams: pmc_approved+ kaloyan: pmc_approved? (raghunathan.srinivasan) kaloyan: pmc_approved? (naci.dai) kaloyan: pmc_approved? (deboer) neil.hauge: pmc_approved+ kaloyan: pmc_approved? (kaloyan) kaloyan: pmc_approved? (cbridgha)
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:	PMC
Bug Depends on:
Bug Blocks:	338060, 347239

Description Kaloyan Raev

2011-05-27 16:00:28 EDT

+++ This bug was initially created as a clone of Bug #347239 +++

I ran a "layout" test, and, according it it, about 10% of the bundles in the Indigo RC2 repo are missing about.html files (or, epl/license files, in features). 

These are often caused by incorrect "build.properties", or similar ... or, I'm sure, in some cases, really missing. 

That percentage seems "better" than last year ... but, still a lot to fix. I'll attach complete list. 

(And, remember ... it is possible the test is in error ... so if anyone finds an error in the reported list, be sure to let me know). 

Be sure to ask if questions or problems ... hopefully these can all be corrected for RC3.

Comment 1 Kaloyan Raev

2011-05-28 01:56:46 EDT

Cleaning the mess I did with cloning the bug.

Comment 2 Kaloyan Raev

2011-05-28 04:30:05 EDT

I went ahead and committed the required changes in the Git repository without waiting for explicit PMC approval. This is not a technical change - just legal files, and this way it was easier for me to test if I did the things correctly. 

    Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

Libra features and plugins are missing important legal files that are required for the Indigo release. 

    Is there a work-around? If so, why do you believe the work-around is insufficient? 

No workaround. 

    How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

I checked manually that the JARs produced by the build include the required legal file. I also checked that the Update Manager shows an up-to-date license info when installing Libra features from the nigtly repository: http://download.eclipse.org/libra/nightly/

    Give a brief technical overview. Who has reviewed this fix? 

Nothing technical - just adding static legal files and updating the feature.properties with up-to-date legal info. There is no patch attached, because in this particular case it is easier to browse the Git repo to check if the changes are made correctly: http://git.eclipse.org/c/libra/org.eclipse.libra.git/tree/

    What is the risk associated with this fix? 

No risk.