Bugzilla – Full Text Bug Listing
| Summary: | Get rid of the test suites | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Rüdiger Herrmann <ruediger.herrmann> | ||||||
| Component: | RWT | Assignee: | Rüdiger Herrmann <ruediger.herrmann> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | ||||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 347573 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Rüdiger Herrmann
Created attachment 196853 [details]
RWTAllTestSuite that returns all classes on the class path that match *_Test
This patch replaces the manual listing of test suites in RWTAllTestSuite with code that scans the class path for classes that match*_Test and adds those classes to the gtest suite.
With these changes, the number of tests increeased from 2615 to 2639. At first glance, it looks like the existing tests suite misses some tests, but this needs further investiagtion.
Several test classes are missing from the test suites (e.g. KeyEvent_Test, NumberFormatUtil_Test, QxShadow_Test, ...). After adding these tests to the respective test suites, the number of tests are the same with both the 'manual' and the 'classpath' test suite. Changes are in CVS HEAD. On the build server, 2.657 tests are executed in total (18 more than RWTAllTestSuite). This is because the tests from org.eclipse.rap.ui.forms.test are also executed. We should consider to integrate these tests into the RWTAllTestSuite. We should consider to also include org.eclipse.rwt.widgets.styledtext.test (another 10 or so tests) Created attachment 197293 [details]
Proposed fix
This patch replaces the current RWTAllTestSuite with the same implementation from patch #1 that dynamically scans the class path for *_Test classes.
In addition, all manual test suites were deleted (e.g. RWTQ07TestSuite, RWTHostTestSuite, ...). To run the same tests that are run on the build server, the tests from org.eclipse.rap.ui.forms.test and org.eclipse.rwt.widgets.styledtext.test have been included.
For now, the mixed dependency declaration in org.eclipse.rwt.test.all was kept. The dependency to JUnit is expressed as a bundle-dependency, whereas dependencies to the test projects are plain JDT classpath entries.
Applied patch from attachment 197293 [details] to CVS HEAD.
|