Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347272

Summary: icons of marketplaces missing in dialog
Product: [Technology] MPC Reporter: Markus Knauer <mknauer>
Component: wizardAssignee: Benjamin Muskalla <b.muskalla>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: b.muskalla, daniel.schaarschmidt, dennis.huebner, ian.skerrett
Version: 1.3.1   
Target Milestone: 1.1   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
screenshot showing the missing icons
none
screenshot Mars M5 none

Description Markus Knauer CLA 2011-05-26 05:21:09 EDT
Created attachment 196646 [details]
screenshot showing the missing icons

I am testing the (Indigo RC2) CPP package, but I've seen this in other Indigo RC1 packages as well: Apart from the Yoxos marketplace icon, all icons of the other marketplaces are missing in the dialog - see attached screenshot.

Bundles being used:

  org.eclipse.epp.mpc.core_1.1.0.I20110525-0742.jar
  org.eclipse.epp.mpc.ui_1.1.0.I20110525-0742.jar
Comment 1 Benjamin Muskalla CLA 2011-05-26 05:49:23 EDT
I saw this some times because marketplace.eclipse.org times out pretty regularly from germany.
Do you see anything in the logs?
Comment 2 Markus Knauer CLA 2011-05-26 05:57:21 EDT
Yepp, there is something in the logs (see below), but the main reason seems to be a 404 and not a time-out... look at this wget output:

wget http://marketplace.eclipse.org/sites/default/files/marketplace32.png
--2011-05-26 11:54:32--  http://marketplace.eclipse.org/sites/default/files/marketplace32.png
Resolving marketplace.eclipse.org... 206.191.52.45
Connecting to marketplace.eclipse.org|206.191.52.45|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2011-05-26 11:54:33 ERROR 404: Not Found.


%< ----------------- log file output

!ENTRY org.eclipse.jface 2 0 2011-05-26 11:37:16.850
!MESSAGE The image could not be loaded: URLImageDescriptor(http://marketplace.eclipse.org/sites/default/files/marketplace32.png)
!STACK 0
org.eclipse.jface.resource.DeviceResourceException: Unable to create resource URLImageDescriptor(http://marketplace.eclipse.org/sites/default/files/marketplace32.png)
	at org.eclipse.jface.resource.ImageDescriptor.createResource(ImageDescriptor.java:167)
	at org.eclipse.jface.resource.DeviceResourceManager.allocate(DeviceResourceManager.java:56)
	at org.eclipse.jface.resource.AbstractResourceManager.create(AbstractResourceManager.java:88)
	at org.eclipse.jface.resource.ResourceManager.createImageWithDefault(ResourceManager.java:192)
	at org.eclipse.jface.resource.ImageRegistry.get(ImageRegistry.java:212)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogSwitcher.getCatalogIcon(CatalogSwitcher.java:161)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogSwitcher.access$4(CatalogSwitcher.java:152)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogSwitcher$3.run(CatalogSwitcher.java:128)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 3 Benjamin Muskalla CLA 2011-05-26 06:00:26 EDT
I think I found the culprit here. The icons don't exist anymore on the server.

Nathan, over to you. The offending images (worked till yesterday) are:

* http://marketplace.eclipse.org/sites/default/files/obeo-marketplace-wizard.png
* http://marketplace.eclipse.org/sites/default/files/obeo-marketplace.png
* http://marketplace.eclipse.org/sites/default/files/marketplace32.png
and maybe others.

Please ensure that all images referenced by http://marketplace.eclipse.org/catalogs/api/p are available.
Comment 4 Nathan Gervais CLA 2011-05-26 10:22:11 EDT
I've replaced the files, no idea why or how these disappeared.

Leaving this open for now.
Comment 5 Daniel Schaarschmidt CLA 2011-06-28 10:30:31 EDT
I'm not sure whether this is the same problem or not, but it looks the same:
Indigo Release (20110615-0604) on Win7x64, I'm sitting behind a proxy

The proxy setup in General>Network Connections is correct, the MPC lists the available plugins correctly. But when it tries to load the marketplace images at the bottom I have to enter my proxy password again (2 times for 2 images), although it is saved in the secure storage and seems to work fine for the rest of the MPC.

If I don't enter my password but press cancel I get the same error Markus mentioned:

org.eclipse.jface.resource.DeviceResourceException: Unable to create resource URLImageDescriptor(http://marketplace.eclipse.org/sites/default/files/marketplace32.png)
	at org.eclipse.jface.resource.ImageDescriptor.createResource(ImageDescriptor.java:167)
	at org.eclipse.jface.resource.DeviceResourceManager.allocate(DeviceResourceManager.java:56)
	at org.eclipse.jface.resource.AbstractResourceManager.create(AbstractResourceManager.java:88)
	at org.eclipse.jface.resource.ResourceManager.createImageWithDefault(ResourceManager.java:192)
	at org.eclipse.jface.resource.ImageRegistry.get(ImageRegistry.java:212)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogSwitcher.getCatalogIcon(CatalogSwitcher.java:161)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogSwitcher.access$4(CatalogSwitcher.java:152)
	at org.eclipse.epp.internal.mpc.ui.wizards.CatalogSwitcher$3.run(CatalogSwitcher.java:128)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 6 Markus Knauer CLA 2011-06-28 10:53:48 EDT
(In reply to comment #5)
> I'm not sure whether this is the same problem or not, but it looks the same:
> Indigo Release (20110615-0604) on Win7x64, I'm sitting behind a proxy

The icon files seem to be there, at least I was able to use the URLs above to load them. My guess is that the download of the icons doesn't respect the proxy settings. Just a guess.
Comment 7 Benjamin Muskalla CLA 2011-06-28 11:25:30 EDT
Will take a look at this for SR1.

And Nathan, next time, please resolve the tasks as fixed after you're done.
Comment 8 Benjamin Muskalla CLA 2011-07-20 23:06:51 EDT
Closing this task as fixed. Remaining proxy issue will be fixed as part of 352691: CatalogSwitcher should respect proxy
https://bugs.eclipse.org/bugs/show_bug.cgi?id=352691
Comment 9 Dennis Huebner CLA 2015-02-11 09:49:30 EST
Created attachment 250727 [details]
screenshot Mars M5

Broken images for markplaces MPC 1.4.0 - Mars M5 DSL Package
Comment 10 Dennis Huebner CLA 2015-02-11 09:50:20 EST
See previous comment
Comment 11 Carsten Reckord CLA 2015-11-24 10:47:57 EST
Loading of catalog and marketplace images has seen a larger rewrite between M5 and the Mars release as part of bug 413871, which should also have fixed this issue. Please reopen - with pertinent log messages if available - if you see this popping up again.
Comment 12 Carsten Reckord CLA 2015-12-16 13:53:20 EST
Cleanup: closing all released fixes.