Bugzilla – Full Text Bug Listing
| Summary: | class files in source bundles | ||
|---|---|---|---|
| Product: | [Modeling] MoDisco | Reporter: | Nicolas Bros <nicolas.bros> |
| Component: | Infrastructure | Assignee: | Nicolas Bros <nicolas.bros> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P1 | CC: | fabien.giquel, gdupe, hugo.bruneliere, Kenn.Hussey, modisco.web-inbox |
| Version: | 0.9.0 | Flags: | nicolas.bros:
indigo+
Kenn.Hussey: pmc_approved+ gdupe: review+ fabien.giquel: review+ |
| Target Milestone: | 0.9.0 RC3 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | 347309 | ||
| Bug Blocks: | 347240 | ||
|
Description
Nicolas Bros
In fact, the problem is not that there is no BREE in a source bundle (that is expected), but that the source bundle contains Java (compiled) classes. I have looked for all ".class" in MoDisco source bundles: ls -1 *modisco*source_* | while read i; do unzip -t $i; done | grep "\.class" And I found the following: org/eclipse/gmt/modisco/java/actions/DiscoverJ2se5ModelFromJavaProject$1.class org/eclipse/gmt/modisco/java/actions/DiscoverJ2se5ModelFromJavaProject$2$1.class org/eclipse/gmt/modisco/java/actions/DiscoverJ2se5ModelFromJavaProject$2.class org/eclipse/gmt/modisco/java/actions/DiscoverJ2se5ModelFromJavaProject.class org/eclipse/gmt/modisco/java/io/java/binding/BijectiveMap.class org/eclipse/gmt/modisco/java/io/java/binding/Binding.class org/eclipse/gmt/modisco/java/io/java/binding/BindingManager$PendingElement.class org/eclipse/gmt/modisco/java/io/java/binding/BindingManager.class org/eclipse/gmt/modisco/java/io/java/binding/ClassBinding.class org/eclipse/gmt/modisco/java/io/java/binding/FeatureBinding.class org/eclipse/gmt/modisco/java/io/java/binding/FieldBinding.class org/eclipse/gmt/modisco/java/io/java/binding/IBindingFactory.class org/eclipse/gmt/modisco/java/io/java/binding/JDTDelegateBindingFactory.class org/eclipse/gmt/modisco/java/io/java/binding/MethodBinding.class org/eclipse/gmt/modisco/java/io/java/binding/PackageBinding.class org/eclipse/gmt/modisco/java/io/java/binding/ParameterBinding.class org/eclipse/gmt/modisco/java/io/java/binding/UnresolvedBinding.class org/eclipse/gmt/modisco/java/io/java/binding/VariableBinding.class I am not sure why these classes are exported in the source bundles. But the org.eclipse.gmt.modisco.java.discoverer plug-in is special in 2 ways: - the package names don't start with the bundle id - the Manifest uses "Provide-Package" instead of "Export-Package" So maybe one of these causes Buckminster (or PDE build called by Buckminster) to export some classes? I tried exporting the bundle locally to investigate the problem, but it makes my Eclipse crash (cf Bug 347309). I finally found the reason there were .class files in the source bundles : the classes really are present in the src/ folder! (I didn't see them at first because they are hidden in the Eclipse Package Explorer) So the solution is simply to remove those .class files. (I tried to attach a patch, but Eclipse won't include modifications to the .class) Hello Kenn and Fabien, This bug is caused by some ".class" files which have been committed in the MoDisco SVN. To solve this bug we just have to remove them. I would like to do it for before RC3. The ".class" files are totally useless. This fix is then totally safe. Do you agree to remove the ".class" files from the SVN. Regards, Gregoire Dupe I removed the classes in revision 4445. I've checked the file org.eclipse.gmt.modisco.java.discoverer.source_0.9.0.v201106080847.jar: it does not contains any .class files. This bug can be closed. Bug solved. |