Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347245

Summary:

Add configurable defaults for Stop in main and for Non-stop mode

Product:

[Tools] CDT

Reporter:

Sergey Prigogin <eclipse.sprigogin>

Component:

cdt-debug-dsf-gdb

Assignee:

Sergey Prigogin <eclipse.sprigogin>

Status:

RESOLVED FIXED

QA Contact:

Marc Khouzam <marc.khouzam>

Severity:

normal

Priority:

CC:

cdtdoug, overholt, pawel.1.piech

Version:

8.0

Flags:

eclipse.sprigogin: iplog-

Target Milestone:

8.0.1

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

348159

Bug Blocks:

Attachments:

Description	Flags
Implementation of configurable global defaults	eclipse.sprigogin: iplog-
Fix for Debug As use case	eclipse.sprigogin: iplog-
Small touchups	marc.khouzam: iplog-

Description Sergey Prigogin

2011-05-25 23:02:43 EDT

Since different groups of users prefer different default settings for "Stop at startup in main" and for "Non-stop mode", these defaults should be configurable at the workspace level.

Comment 1 Sergey Prigogin

2011-05-25 23:04:25 EDT

Created attachment 196623 [details]
Implementation of configurable global defaults

Comment 2 Sergey Prigogin

2011-05-25 23:06:05 EDT

Fixed in HEAD > 20110525.

Comment 3 CDT Genie

2011-05-25 23:23:07 EDT

*** cdt cvs genie on behalf of sprigogin ***
Bug 347245 - Add configurable defaults for Stop in main and for Non-stop mode.

[*] GdbDebuggerPage.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/launching/GdbDebuggerPage.java?root=Tools_Project&r1=1.10&r2=1.11
[*] CDebuggerTab.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/launching/CDebuggerTab.java?root=Tools_Project&r1=1.8&r2=1.9

[*] GdbPreferenceInitializer.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/preferences/GdbPreferenceInitializer.java?root=Tools_Project&r1=1.6&r2=1.7
[*] GdbDebugPreferencePage.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/preferences/GdbDebugPreferencePage.java?root=Tools_Project&r1=1.11&r2=1.12

[*] IGdbDebugPreferenceConstants.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/IGdbDebugPreferenceConstants.java?root=Tools_Project&r1=1.6&r2=1.7

Comment 4 Marc Khouzam

2011-05-26 11:20:01 EDT

Nice.
Thanks Sergey.

Comment 5 Marc Khouzam

2011-05-26 11:59:09 EDT

I've updated the CDT N&N about this change.
http://wiki.eclipse.org/CDT/User/NewIn80#New_set_of_preferences

Comment 6 Marc Khouzam

2011-05-26 13:02:54 EDT

Sergey, if you create a new project and right-click, Debug As..., the new preferences are not respected.  We need the same set of changes as what was done in Bug 120162 comment #13

Comment 7 Sergey Prigogin

2011-05-26 20:07:29 EDT

Created attachment 196715 [details]
Fix for Debug As use case

Comment 8 Sergey Prigogin

2011-05-26 20:09:25 EDT

Fixed in HEAD > 20110526.

Comment 9 CDT Genie

2011-05-26 20:23:08 EDT

*** cdt cvs genie on behalf of sprigogin ***
Bug 347245 - Add configurable defaults for Stop in main and for Non-stop mode. Use global preferences for Debug As command.

[*] LaunchUtils.java 1.23 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/LaunchUtils.java?root=Tools_Project&r1=1.22&r2=1.23
[*] FinalLaunchSequence.java 1.25 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/FinalLaunchSequence.java?root=Tools_Project&r1=1.24&r2=1.25

[*] StartOrRestartProcessSequence_7_0.java 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/StartOrRestartProcessSequence_7_0.java?root=Tools_Project&r1=1.13&r2=1.14

[*] CApplicationLaunchShortcut.java 1.13 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/launch/CApplicationLaunchShortcut.java?root=Tools_Project&r1=1.12&r2=1.13

Comment 10 Marc Khouzam

2011-05-26 21:09:11 EDT

Created attachment 196718 [details]
Small touchups

(In reply to comment #7)
> Created attachment 196715 [details]
> Fix for Debug As use case

Thanks.
I added a couple more little things for the JTag launch and for older GDB versions (GDBProcesses).
I also renamed getStopInMain*() to getStopAtMain*()

Committed to HEAD.

Comment 11 CDT Genie

2011-05-26 21:23:08 EDT

*** cdt cvs genie on behalf of mkhouzam ***
Bug 347245: Add configurable defaults for Stop in main and for Non-stop mode

[*] LaunchUtils.java 1.24 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/LaunchUtils.java?root=Tools_Project&r1=1.23&r2=1.24

[*] StartOrRestartProcessSequence_7_0.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/StartOrRestartProcessSequence_7_0.java?root=Tools_Project&r1=1.14&r2=1.15
[*] GDBProcesses.java 1.30 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBProcesses.java?root=Tools_Project&r1=1.29&r2=1.30

[*] GDBJtagDSFFinalLaunchSequence.java 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/jtag/org.eclipse.cdt.debug.gdbjtag.core/src/org/eclipse/cdt/debug/gdbjtag/core/GDBJtagDSFFinalLaunchSequence.java?root=Tools_Project&r1=1.16&r2=1.17

Comment 12 Sergey Prigogin

2011-05-26 21:33:31 EDT

(In reply to comment #10)
> I added a couple more little things for the JTag launch and for older GDB
> versions (GDBProcesses).
> I also renamed getStopInMain*() to getStopAtMain*()

Thanks. I was afraid to touch JTag stuff since I didn't know how to test it.

Comment 13 Marc Khouzam

2011-06-03 14:12:19 EDT

I've had to back out a part of "Fix for Debug As use case" as part of Bug 348159.

I broke the "Debug As" use case, but it was the lesser of two evils.

Details in Bug 348159 comment 2

Comment 14 Marc Khouzam

2011-06-27 16:42:58 EDT

(In reply to comment #13)
> I've had to back out a part of "Fix for Debug As use case" as part of Bug
> 348159.
> 
> I broke the "Debug As" use case, but it was the lesser of two evils.

I put back what I had backed out, now that Bug 348159 was properly fixed.