Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347228

Summary:

AdapterFactoryEditingDomain.isReadOnly(Resource) should request ATTRIBUTE_READ_ONLY only

Product:

[Modeling] EMF

Reporter:

Mario Winterer <mario.winterer>

Component:

Edit

Assignee:

Ed Merks <Ed.Merks>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch that requests ATTRIBUTE_READ_ONLY only	none

Description Mario Winterer

2011-05-25 17:50:42 EDT

Build Identifier: 20090619-0625

The current implementation of AdapterFactoryEditingDomain.isReadOnly(Resource) fetches all attributes via URIConverter.getAttributes instead of just fetching the attribute ATTRIBUTE_READ_ONLY (using an option map).
This causes additional unnecessary server requests for web resources (http).
(see also URIHandlerImpl.getAttributes(URI, Map) )

Reproducible: Always

Comment 1 Mario Winterer

2011-05-25 18:02:52 EDT

Created attachment 196613 [details]
Patch that requests ATTRIBUTE_READ_ONLY only

This patch uses the request attributes option (URIConverter.OPTION_REQUESTED_ATTRIBUTES) to narrow the attribute request to URIConverter.ATTRIBUTE_READ_ONLY only.

Comment 2 Ed Merks

2011-10-27 13:03:50 EDT

The fix is committed to CVS for 2.8.

Comment 3 Ed Merks

2011-11-22 05:26:49 EST

The changes are available in builds.