Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347124

Summary:

[Wizards] Import Team Project Set page is missing mnemonics for radio buttons (File/URL)

Product:

[Eclipse Project] Platform

Reporter:

Tomasz Zarna <tomasz.zarna>

Component:

Team

Assignee:

Malgorzata Janczarska <malgorzata.tomczyk>

Status:

VERIFIED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

daniel_megert, pwebster, serge, Szymon.Brandys

Version:

3.7

Flags:

pwebster: review+
Szymon.Brandys: review+
daniel_megert: review+
serge: review+

Target Milestone:

3.7 RC3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Added mnemonics	none
New screenshoot	none
Added mnemonics	daniel_megert: review+
New screenshoot	none
New screenshoot	none
properly updated screenshot	none
mylyn/context/zip	none

Description Tomasz Zarna

2011-05-25 05:13:18 EDT

Caused by bug 162608.

"File name" had "i" as mnemonic. Now neither "File" nor "URL" have one.

Comment 1 Tomasz Zarna

2011-05-25 05:14:10 EDT

Spotted while fixing bug 346447, so when fixed the screenshot from that bug should be updated as well.

Comment 2 Malgorzata Janczarska

2011-05-25 06:03:33 EDT

Created attachment 196527 [details]
Added mnemonics

Comment 3 Malgorzata Janczarska

2011-05-25 06:06:23 EDT

Created attachment 196528 [details]
New screenshoot

Comment 4 Tomasz Zarna

2011-05-25 06:14:33 EDT

(In reply to comment #3)
> Created attachment 196528 [details]
> New screenshoot

The original screenshot has different theme, I wouldn't change that.

Comment 5 Tomasz Zarna

2011-05-25 06:17:42 EDT

(In reply to comment #2)
> Created attachment 196527 [details]
> Added mnemonics

The new mnemonic for "File" (F) is different than the previously used for "File name" (i). I would keep them the same. Don't forget to update copyrights.

Comment 6 Malgorzata Janczarska

2011-05-25 06:49:25 EDT

Created attachment 196531 [details]
Added mnemonics

Comment 7 Malgorzata Janczarska

2011-05-25 06:50:00 EDT

Created attachment 196532 [details]
New screenshoot

Comment 8 Malgorzata Janczarska

2011-05-25 07:03:26 EDT

Created attachment 196535 [details]
New screenshoot

Comment 9 Dani Megert

2011-05-25 07:06:45 EDT

You need 3 review+ for RC3.

The screenshot looks blurred. Did you follow the
http://wiki.eclipse.org/Eclipse_Doc_Style_Guide? Especially:
(*) Display Properties > Appearance > Effects > Use the following method to
smooth edges of screen fonts: Off (Not checked)

+1 for RC3 for the code change.

Comment 10 Tomasz Zarna

2011-05-25 07:23:15 EDT

Created attachment 196537 [details]
properly updated screenshot

Comment 11 Tomasz Zarna

2011-05-25 07:23:21 EDT

Created attachment 196538 [details]
mylyn/context/zip

Comment 12 Paul Webster

2011-05-25 07:40:59 EDT

Looks fine.
PW

Comment 13 Serge Beauchamp

2011-05-25 07:41:20 EDT

I review the fix and it looks good.

Comment 14 Tomasz Zarna

2011-05-25 07:43:35 EDT

Thanks guys! Applied to HEAD. Mnemonics will be available in builds >=20110525-0800.

Comment 15 Dani Megert

2011-05-26 01:54:12 EDT

Verified in I20110525-0800.

Filed bug 347250 for missing link in F1 help.