Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347078

Summary:	Egit harms Eclipse UI guidelines
Product:	[Technology] EGit	Reporter:	Holger Staudacher <holger.staudacher>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	CLOSED INVALID	QA Contact:
Severity:	normal
Priority:	P3	CC:	robin.rosenberg
Version:	1.0
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Holger Staudacher

2011-05-24 16:16:08 EDT

Most of the Egit UI components does harm the Eclipse UI guidelines [1]. Especially the Staging view. 

The problems are not big, mostly it's spacing ;) I think that a team provider is such an important component that it should integrate itself well into the rest of the IDE.

[1] http://www.eclipse.org/articles/Article-UI-Guidelines/Contents.html

Comment 1 Robin Rosenberg

2011-06-05 19:41:41 EDT

It takes time to learn UI guidelines, so anyone who has not spent a *lot* of
time designing Eclipse UI's will miss stuff. It would be much easier if you could be specific about the issues you have noticed. Opening an issue on the
Staging view pointing out the issues will get them resolved and probably some others too.

UI issues may appear differently on different platforms, so the developers may not even see what you see,

It's good to get a reminder that such a document exists.

I added a section on coding conventions and user interface guidelines to the contributor's guide in the wiki.

Comment 2 Robin Rosenberg

2013-05-27 15:34:58 EDT

No specifics