Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347077

Summary:	Make Gerrit features Optional
Product:	[Technology] EGit	Reporter:	Holger Staudacher <holger.staudacher>
Component:	UI	Assignee:	Project Inbox <egit.core-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	caniszczyk, cdtdoug, matthias.sohn, robin
Version:	1.0
Target Milestone:	3.1
Hardware:	All
OS:	All
Whiteboard:

Description Holger Staudacher

2011-05-24 16:11:12 EDT

The context menu of a repository has the entry "Fetch from Gerrit". This only make sense if you use gerrit. I think the majority does not. So, my suggestion is to make this feature at least configurable. It should be hidden by default because it confuses users to have so many fetch possibilities.

Maybe there can be something called "Enable Gerrit features" in the preferences or a separate feature for this. But in my opinion the gerrit features should be not available in standard egit. This is the same with the "compute change-id" option in the commit dialog.

Comment 1 Chris Aniszczyk

2011-05-24 18:03:43 EDT

Sure, it only makes sense if you use Gerrit. Having a feature in the future that separates things make sense in my opinion.

For now, we will ship things combined because that's how we setup development at eclipse.org... and when Gerrit gets deployed at eclipse.org... more people will use it.

Comment 2 Robin Stocker

2013-09-29 10:56:19 EDT

This has been fixed in 3.1 with change Ie1f1d5d: https://git.eclipse.org/c/egit/egit.git/commit/?id=85f17521576061d2facb8bbaf1bcee74c76c833c

Comment 3 Doug Schaefer

2014-02-26 16:35:41 EST

Except now, the Gerrit features are undiscoverable. Shouldn't there be an automatic trigger, like if one of the remotes has a 29419 port on it's URL?

Comment 4 Matthias Sohn

2014-02-26 16:57:10 EST

(In reply to Doug Schaefer from comment #3)
> Except now, the Gerrit features are undiscoverable. Shouldn't there be an
> automatic trigger, like if one of the remotes has a 29419 port on it's URL?

click "Gerrit configuration..." on the remote pointing to your Gerrit server, after that the Gerrit menus are enabled, this is based on auto-discovering a push refspec starting with refs/for or configuration option gerrit.createchangeid=true

This means this will also work if you configure a refs/for push refspec or gerrit.createchangeid=true manually

Comment 5 Doug Schaefer

2014-02-26 16:57:50 EST

Sorry, just looked at the comment in the change request. Good thing I found it. Would never have know now to turn on the Gerrit menu items without it.

Comment 6 Matthias Sohn

2014-02-26 17:00:28 EST

(In reply to Doug Schaefer from comment #5)
> Sorry, just looked at the comment in the change request. Good thing I found
> it. Would never have know now to turn on the Gerrit menu items without it.

do you think we should make this more obvious ? if yes, how ?

Comment 7 Doug Schaefer

2014-02-26 17:05:47 EST

No, just more automatic. Looking for refs/for is a good example. I imagine if a remote URL has 29418 as it's port, you could turn it on as well.