Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 347050

Summary:

NPE in ProgressStatistics for URLs without filename

Product:

[Eclipse Project] Equinox

Reporter:

Benjamin Muskalla <b.muskalla>

Component:

Assignee:

DJ Houghton <dj.houghton>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

dj.houghton, pascal, tjwatson

Version:

unspecified

Flags:

tjwatson: pmc_approved+
pascal: review+
john.arthorne: review+

Target Milestone:

3.7 RC3

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
patch	none

Description Benjamin Muskalla

2011-05-24 14:49:47 EDT

Use Transport to stream a url without a filename (eg. "http://www.eclipse.org") leads to the following NPE.
This regression was introduced with the following bugfix which doesn't check for m_fileName == null:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=338560

Caused by: java.lang.NullPointerException
	at java.lang.String.endsWith(String.java:1465)
	at org.eclipse.equinox.internal.p2.repository.ProgressStatistics.report(ProgressStatistics.java:129)
	at org.eclipse.equinox.internal.p2.transport.ecf.FileReader.handleTransferEvent(FileReader.java:164)
	at org.eclipse.ecf.provider.filetransfer.retrieve.AbstractRetrieveFileTransfer.fireReceiveStartEvent(AbstractRetrieveFileTransfer.java:671)
	at org.eclipse.ecf.provider.filetransfer.httpclient.HttpClientRetrieveFileTransfer.openStreams(HttpClientRetrieveFileTransfer.java:735)
	at org.eclipse.ecf.provider.filetransfer.retrieve.AbstractRetrieveFileTransfer.sendRetrieveRequest(AbstractRetrieveFileTransfer.java:889)
	at org.eclipse.ecf.provider.filetransfer.retrieve.AbstractRetrieveFileTransfer.sendRetrieveRequest(AbstractRetrieveFileTransfer.java:576)
	at org.eclipse.ecf.provider.filetransfer.retrieve.MultiProtocolRetrieveAdapter.sendRetrieveRequest(MultiProtocolRetrieveAdapter.java:98)
	at org.eclipse.equinox.internal.p2.transport.ecf.FileReader.sendRetrieveRequest(FileReader.java:349)
	at org.eclipse.equinox.internal.p2.transport.ecf.FileReader.read(FileReader.java:213)
	at org.eclipse.equinox.internal.p2.transport.ecf.RepositoryTransport.stream(RepositoryTransport.java:146)
	... 65 more

Comment 1 DJ Houghton

2011-05-24 15:33:39 EDT

Created attachment 196481 [details]
patch

Comment 2 DJ Houghton

2011-05-25 10:51:35 EDT

Released.

Comment 3 Benjamin Muskalla

2011-05-26 11:42:55 EDT

Thanks for the quick fix DJ.