| Summary: | [region] Add an isAllowed method to RegionFilter that checks if a generic namespace/attributes are allowed | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Thomas Watson <tjwatson> | ||||||
| Component: | Components | Assignee: | Thomas Watson <tjwatson> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | glyn.normington, jwross | ||||||
| Version: | 3.7 | ||||||||
| Target Milestone: | Juno M6 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Thomas Watson
Created attachment 196471 [details]
patch and small test
Here is the patch. Again I am not sure this is a great idea. Just do not want to loose my work.
Created attachment 211368 [details]
updated patch
Here is an updated git patch. It is pretty much the same as the original except I fixed up the testcase.
Glyn, I think we need to do something like this for subsystems. We need the ability to traverse the digraph connection based on simple namespace and attributes in order to verify some existing or future capability would be visible to a given region based on the connections. Could you have a closer look at the proposed API and provide feedback?
Comment on attachment 211368 [details]
updated patch
The new API seems reasonable but I'd prefer it to summarise what is meant by a namespace.
(In reply to comment #3) > Comment on attachment 211368 [details] > updated patch > > The new API seems reasonable but I'd prefer it to summarise what is meant by a > namespace. I updated the javadoc in an attempt to clarify namespace: http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=1f744506dfe032383827e8a14775106e188a2d1f I added another clarification to define name space in commit: http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=7dcad19d3d9008f024ed6c247b67675ca56f3c7c Thanks Tom. That will job my memory and help newcomers. s /job/jog/ |