Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346962

Summary:	Choose... dialog for "File name patterns" should not change non-extension patterns
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	Search	Assignee:	Platform-Search-Inbox <platform-search-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert
Version:	3.7
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:	stalebug

Description Markus Keller

2011-05-24 06:35:01 EDT

I20110519-1138

In the File Search dialog, the Choose... dialog for "File name patterns" should not change non-extension patterns.

Currently, just clicking Choose... and then OK e.g. changes
*.properties, plugin.xml -> *.properties
!plugin.xml, *.xml -> *.!plugin.xml, *.xml

Looks like TypeFilteringDialog was only intended to be used to select extensions, not whole file name patterns. Unfortunately, the class Javadoc is completely wrong and the constructor Javadocs are also not helpful.

Comment 1 Dani Megert

2011-05-24 08:17:38 EDT

One of the problems is in TypeFilteringDialog when one enters a file name that is also registered as file type (see 'File Associations' page).

This is broken for years. Will take a look during 3.8.

Comment 2 Lars Vogel

2019-11-14 03:32:40 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.