Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346936

Summary:

Some source features are generated without the "Source for " prefix

Product:

z_Archived

Reporter:

Eike Stepper <stepper>

Component:

Buckminster

Assignee:

buckminster.core-inbox <buckminster.core-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

thomas

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Screenshot 1	none
Screenshot 2	none
Good feature.xml from Screenshot 1	none
Good feature.properties from Screenshot 1	none
Bad feature.xml from Screenshot 1	none
Bad feature.properties from Screenshot 1	none

Description Eike Stepper

2011-05-24 03:08:51 EDT

I noticed that some of my source features are generated without the "Source for " prefix while others have this prefix. I've attached two install screenshots that illustrate this problem. When I compare the "good" features with the "bad" ones I can see no relevant difference. 

It seems that the entire feature.properties file in the wrong *source* features is an *exact* copy of their code features. Also the description is wrong... 

I'll attach some example artifacts in a second...

Observed with:
org.eclipse.buckminster.cmdline.product 1.4.0.r11728.
org.eclipse.buckminster.core.headless.feature.feature.group 1.4.0.r11769.
org.eclipse.buckminster.pde.headless.feature.feature.group 1.4.0.r11787.
org.eclipse.buckminster.subversive.headless.feature.feature.group 1.4.0.r11717.
org.eclipse.buckminster.emma.headless.feature.feature.group 0.9.0.r11680.

Example:
https://hudson.eclipse.org/hudson/job/emf-cdo-integration/lastSuccessfulBuild/artifact/result/site.p2

Note: I've elevated the severity to major because I think that the first time experience of users is during install time and it looks quite confusing if features (feature names) appear duplicated in the p2 client. It would be very nice to have this fixed for Indigo RC3 or RC4 latest. Thanks ;-)

Comment 1 Eike Stepper

2011-05-24 03:09:34 EDT

Created attachment 196398 [details]
Screenshot 1

Comment 2 Eike Stepper

2011-05-24 03:09:53 EDT

Created attachment 196399 [details]
Screenshot 2

Comment 3 Eike Stepper

2011-05-24 03:11:35 EDT

Created attachment 196401 [details]
Good feature.xml from Screenshot 1

Comment 4 Eike Stepper

2011-05-24 03:11:59 EDT

Created attachment 196402 [details]
Good feature.properties from Screenshot 1

Comment 5 Eike Stepper

2011-05-24 03:12:21 EDT

Created attachment 196403 [details]
Bad feature.xml from Screenshot 1

Comment 6 Eike Stepper

2011-05-24 03:12:45 EDT

Created attachment 196404 [details]
Bad feature.properties from Screenshot 1

Comment 7 Thomas Hallgren

2011-05-26 07:05:27 EDT

Comment on attachment 196402 [details]
Good feature.properties from Screenshot 1

># Copyright (c) 2004 - 2011 Eike Stepper (Berlin, Germany) and others.
># All rights reserved. This program and the accompanying materials
># are made available under the terms of the Eclipse Public License v1.0
># which accompanies this distribution, and is available at
># http://www.eclipse.org/legal/epl-v10.html
>
>featureName = CDO Dawn Examples
>description = Contains example plugins to demonstrate a range of functions of Dawn.

Comment 8 Thomas Hallgren

2011-05-26 08:23:56 EDT

All files were generated correctly but the final copy involving licenses etc. from the original feature also contained the feature.properties. In some cases that file managed to overwrite the generated file and the order of the copy was somewhat random. The cspec will now always exclude the orginial feature.properties in this copy.

Fixed in trunk, rev 11792. I'll start a new build immediately.

Comment 9 Eike Stepper

2011-05-26 12:48:15 EDT

Thank you, it looks beautiful now ;-)