Bugzilla – Full Text Bug Listing
| Summary: | Export Test Result Details in the Test Result Summary View is misnamed | ||
|---|---|---|---|
| Product: | [Technology] Jubula | Reporter: | Tim Winselmann <tim.winselmann> |
| Component: | Core | Assignee: | Zeb Ford-Reitz <zeb.ford-reitz> |
| Status: | CLOSED FIXED | QA Contact: | Oliver Goetz <Oliver.Goetz> |
| Severity: | normal | ||
| Priority: | P3 | CC: | Achim.Loerke, alexandra.schladebeck, zeb.ford-reitz |
| Version: | 0.9.0 | ||
| Target Milestone: | Kepler | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Attachments: | |||
|
Description
Tim Winselmann
Fixed label with http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=7313b0ca57665bf353937143e60b05c409362653 I think we should simply enhance / change the icon to differ from "Open in Test Result Viewer"-action. Please verify label change and create / alter icon (@TW). The label is still "Test Result Details". Created attachment 211560 [details]
stack trace of method call that resets contribution label to wizard name
The contribution label, even if explicitly set in plugin.xml, gets reset automagically to the wizard name. I've attached a stack trace of where this occurs.
Created attachment 211561 [details]
patch for explicitly setting the contribution label
I'm attaching the patch to explicitly set the contribution label even though it proved ineffective.
Resolving as WONTFIX because the label (and icon) cannot be set explicitly. They are fully dependent on the wizard name and icon. Changing the wizard name and icon would cause the wizard to appear incorrectly in the general export wizard dialog (i.e. all other wizards would be named based on *what* they export, and this wizard would be named "Export" or "Export Test Result Details..."). Created attachment 211562 [details]
patch for explicitly setting the contribution label
Closing this ticket A possible solution occurred to me while working on another problem: Add a new Command (and corresponding Handler) for "Export Test Result Details" and add this Command to the toolbar / menu instead of the parameterized Export Wizard Command. The Handler could then invoke the parameterized Export Wizard Command. This solution (if workable) provides more fine-grained control over: * name (Export Test Result Details) * icon (an "export" arrow in addition to the Test Results icon) * enablement (disabled if no Test Result Summaries with details are selected) * error handling (if an error occurs while processing the selection, we could present a dialog instead of the export wizard) If this solution proves workable, it might be worth applying it to otehr wizards in Jubula (ex. Import Central Test Data). fixed on master with: http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=02423efdd282ad767e8a3e051d4def1b4e2f6d3c Comment on attachment 211560 [details]
stack trace of method call that resets contribution label to wizard name
This attachment did not contribute in any way to the solution that was actually used.
Comment on attachment 211562 [details]
patch for explicitly setting the contribution label
This attachment did not contribute in any way to the solution that was actually used.
Tested using current GD. |