Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346693

Summary: [Memory Browser]Automatically open memory rendering when a target is selected and Memory Browser is already opened.
Product: [Tools] CDT Reporter: Alain Lee <a-lee>
Component: cdt-memoryAssignee: cdt-debug-inbox <cdt-debug-inbox>
Status: NEW --- QA Contact: Jonah Graham <jonah>
Severity: major    
Priority: P3 CC: cdtdoug, pawel.1.piech, Randy.Rohrbach
Version: 8.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch to open a rendering automatically
none
patch to incorporate Randy's suggestion
none
patch to incorporate Randy's suggestion none

Description Alain Lee CLA 2011-05-20 10:42:42 EDT 
This is what a scenarioto view the memory data based on the currently behaviour of Memory Browser:
1. Open Memory Browser.
2. Start a debug session
3. Select a target
4. Enter an expression in the Go To Address box and click Go

What our customers want to do is:
1. Open Memory Browser
2. Start a debug session.
3. Select a target.
4. A rendering is automatically opened and jump to address that was previously viewed. 
5. If a rendering for the same is removed by the users and the same target is selected again, memory browser does not need to automatically open a rendering again.

The following changes can be implemented in Memory Browser:
1. Whenever users enter an expression to the Go To Address field, Memory Browser will store the expression and tne memory space id in the launch configuration. 
2. Currently, Memory Browser creates a tab folder only when a valid context is selected and a tab folder for the context has not yet been created. We can add an additinal task there to open a memory rendering and jump to the address that has been stored from the previous step.
Comment 1 Alain Lee CLA 2011-05-25 15:53:47 EDT 
Created attachment 196603 [details]
patch to open a rendering automatically
Comment 2 Randy Rohrbach CLA 2011-05-26 13:42:05 EDT 
Alain

   I applied the patch and it works as advertised. I guess I am wondering
   if this is the right thing to do. What you have saves and restores the
   last expression/renderer selected/created. Why just the last.  Had you
   considered saving and restoring all of them. Doing one or all is quite
   a change from existing behavior. I like it by the way, but again wonder
   if it is enough. Also I am wondering, since this is a pretty significant
   UI workflow change, had you considered making this a preference that the
   user could use to decide if they want this behavior or not.

Randy
Comment 3 Alain Lee CLA 2011-05-26 14:05:40 EDT 
(In reply to comment #2)
> Alain
>    I applied the patch and it works as advertised. I guess I am wondering
>    if this is the right thing to do. What you have saves and restores the
>    last expression/renderer selected/created. Why just the last.  Had you
>    considered saving and restoring all of them. Doing one or all is quite
>    a change from existing behavior. I like it by the way, but again wonder
>    if it is enough. Also I am wondering, since this is a pretty significant
>    UI workflow change, had you considered making this a preference that the
>    user could use to decide if they want this behavior or not.
> Randy

Randy,

Did you mean to restore all renderings that were left opened in the last session? I think this is a good approach if I didn't misundertand you. I also agree that we should let users decide whether they want this behaviour or not.
Comment 4 Randy Rohrbach CLA 2011-05-26 15:30:11 EDT 
Alain

   yes, I meant restoring all renderers for a particular context.
    
   Whether or not you decide to do this, I think the patch should
   make it an option and I think you should query the CDT community
   ( cdt_dev ) about putting in this more significant change.

   For sure it needs to be a preference option. Whether or not the
   default is ON or OFF, should be decided by the community.

Randy
Comment 5 Alain Lee CLA 2011-05-31 16:34:53 EDT 
Created attachment 197046 [details]
patch to incorporate Randy's suggestion
Comment 6 Alain Lee CLA 2011-06-07 16:16:26 EDT 
Created attachment 197541 [details]
patch to incorporate Randy's suggestion