Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346686

Summary: IllegalArgumentException inside exporting session from API compare view
Product: [Eclipse Project] PDE Reporter: Olivier Thomann <Olivier_Thomann>
Component: API ToolsAssignee: Olivier Thomann <Olivier_Thomann>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public, daniel_megert, Michael_Rennie
Version: 3.7Flags: curtis.windatt.public: review+
Michael_Rennie: review+
daniel_megert: review+
Target Milestone: 3.7 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Proposed fix daniel_megert: review+

Description Olivier Thomann CLA 2011-05-20 10:13:49 EDT 
Using latest, I got this IllegalArgumentException, when trying to export a session in a html file. I clicked on cancel first:

java.lang.IllegalArgumentException: Argument cannot be null
	at org.eclipse.swt.SWT.error(SWT.java:4258)
	at org.eclipse.swt.SWT.error(SWT.java:4192)
	at org.eclipse.swt.SWT.error(SWT.java:4163)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:468)
	at org.eclipse.swt.widgets.Text.setText(Text.java:1965)
	at org.eclipse.pde.api.tools.ui.internal.actions.ExportDialog$3.widgetSelected(ExportDialog.java:238)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:240)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4163)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3752)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
	at org.eclipse.jface.window.Window.open(Window.java:801)
	at org.eclipse.pde.api.tools.ui.internal.actions.ExportSessionAction.run(ExportSessionAction.java:72)
	at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
	at org.eclipse.jface.action.ActionContributionItem$6.handleEvent(ActionContributionItem.java:452)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4163)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3752)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:944)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:860)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:87)
	at org.eclipse.ui.internal.Workbench$3.run(Workbench.java:542)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:522)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
Comment 1 Olivier Thomann CLA 2011-05-20 10:13:58 EDT 
I'll investigate.
Comment 2 Olivier Thomann CLA 2011-05-20 10:25:56 EDT 
Created attachment 196224 [details]
Proposed fix
Comment 3 Olivier Thomann CLA 2011-05-20 10:26:48 EDT 
Curtis, please review.
I would release for RC3 as there is no workaround and it looks bad to get an error in the log for doing something that simple.
Comment 4 Olivier Thomann CLA 2011-05-20 10:27:03 EDT 
Michael, please review.
Comment 5 Olivier Thomann CLA 2011-05-20 10:27:20 EDT 
Daniel, please review.
Comment 6 Michael Rennie CLA 2011-05-20 10:45:20 EDT 
+1 looks good
Comment 7 Dani Megert CLA 2011-05-23 04:56:37 EDT 
+1 for RC2.
Comment 8 Dani Megert CLA 2011-05-23 04:56:48 EDT 
+1 for RC3.
Comment 9 Curtis Windatt CLA 2011-05-23 11:25:53 EDT 
+1 for RC3
Comment 10 Olivier Thomann CLA 2011-05-23 16:11:11 EDT 
Released for RC3.
Comment 11 Dani Megert CLA 2011-05-25 03:18:23 EDT 
Verified in I20110524-0900.