Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346680

Summary:	Keybindings overlap with JDT
Product:	[Technology] EGit	Reporter:	Jan Koehnlein <jan>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	major
Priority:	P3	CC:	matthias.sohn, pwebster, sebastian.zarnekow, sven.efftinge
Version:	unspecified
Target Milestone:	---
Hardware:	Macintosh
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Jan Koehnlein

2011-05-20 09:49:57 EDT

Running an Eclipse with JDT and eGit installed, I get the following error messages:


!ENTRY org.eclipse.jface 2 0 2011-05-20 15:44:31.540
!MESSAGE Keybinding conflicts occurred.  They may interfere with normal accelerator operation.
!SUBENTRY 1 org.eclipse.jface 2 0 2011-05-20 15:44:31.540
!MESSAGE A conflict occurred for ALT+COMMAND+C:
Binding(ALT+COMMAND+C,
	ParameterizedCommand(Command(org.eclipse.egit.ui.team.Commit,Commit,
		,
		Category(org.eclipse.egit.ui.commandCategory,Git,null,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
Binding(ALT+COMMAND+C,
	ParameterizedCommand(Command(org.eclipse.jdt.ui.edit.text.java.modify.method.parameters,Change Method Signature,
		Change method signature includes parameter names and parameter order,
		Category(org.eclipse.jdt.ui.category.refactoring,Refactor - Java,Java Refactoring Actions,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,cocoa,system)
!SUBENTRY 1 org.eclipse.jface 2 0 2011-05-20 15:44:31.540
!MESSAGE A conflict occurred for ALT+COMMAND+M:
Binding(ALT+COMMAND+M,
	ParameterizedCommand(Command(org.eclipse.egit.ui.team.Merge,Merge,
		,
		Category(org.eclipse.egit.ui.commandCategory,Git,null,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
Binding(ALT+COMMAND+M,
	ParameterizedCommand(Command(org.eclipse.jdt.ui.edit.text.java.extract.method,Extract Method,
		Extract a set of statements or an expression into a new method and use the new method,
		Category(org.eclipse.jdt.ui.category.refactoring,Refactor - Java,Java Refactoring Actions,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,cocoa,system)
!SUBENTRY 1 org.eclipse.jface 2 0 2011-05-20 15:44:31.540
!MESSAGE A conflict occurred for ALT+COMMAND+I:
Binding(ALT+COMMAND+I,
	ParameterizedCommand(Command(org.eclipse.egit.ui.team.Ignore,Ignore,
		,
		Category(org.eclipse.egit.ui.commandCategory,Git,null,true),
		org.eclipse.egit.ui.internal.actions.IgnoreActionHandler,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
Binding(ALT+COMMAND+I,
	ParameterizedCommand(Command(org.eclipse.jdt.ui.edit.text.java.inline,Inline,
		Inline a constant, local variable or method,
		Category(org.eclipse.jdt.ui.category.refactoring,Refactor - Java,Java Refactoring Actions,true),
		,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,cocoa,system)

Comment 1 Jan Koehnlein

2011-06-23 05:46:24 EDT

This effectively kills keybindings I often use for triggering JDT refactorings. 

Even worse, the key storkes insert special characters now: "extract method" now inserts a "mu" character, "change methods" inserts a "c-sedit", "Inline" a backslash.

Please also consider using capabilites to enable users to switch of these contributions.

Comment 2 Sven Efftinge

2011-06-27 05:56:24 EDT

This effectively removes the short cut for "Extract Method" in Java editors, which is one of the shortcuts  I use heavily.

The problem just happens with Carbon, because JDT has a special shortcut for that platform.
From jdt.ui's plugin.xml :

      <key
            sequence="M2+M3+M"
            commandId="org.eclipse.jdt.ui.edit.text.java.extract.method"
            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"/>
      <key
            platform="carbon"
            sequence="M2+M3+M"
            commandId=""
            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"/>
      <key
            platform="carbon"
            sequence="COMMAND+ALT+M"
            commandId="org.eclipse.jdt.ui.edit.text.java.extract.method"
            schemeId="org.eclipse.ui.defaultAcceleratorConfiguration"/>

Comment 3 Matthias Sohn

2011-06-28 04:28:17 EDT


*** This bug has been marked as a duplicate of bug 321739 ***