Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346665

Summary:	Extension editor corrupts plugin.xml
Product:	[Eclipse Project] PDE	Reporter:	Greg Watson <g.watson>
Component:	UI	Assignee:	PDE-UI-Inbox <pde-ui-inbox>
Status:	CLOSED INVALID	QA Contact:
Severity:	normal
Priority:	P3	CC:	curtis.windatt.public, daniel_megert
Version:	3.7
Target Milestone:	3.8
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Greg Watson

2011-05-20 08:43:20 EDT

(Copied from bug 331485)

I have encountered another issue that corrupts the plugin.xml. It appears that
the escaping of certain special characters does not work properly. 

I don't have a test case, but you can try it out by creating an extension point
that has a string field. Try creating and extension and entering some text in
the field that contains special characters such as ", ', ;, etc. The initial
conversion seems to work ok, but if you subsequently edit the string (remove a
special character, add new ones, etc.) the field is eventually corrupted. Just
play around a bit and you should see it.

It seems particularly vulnerable when adding/inserting a semicolon in the
string if it already contains escaped characters. So if a string contains 'foo'
(including the single quotes), then adding a semicolon to the end seems to
corrupt it.

Comment 1 Dani Megert

2011-05-20 08:48:33 EDT

Greg, which build are you using?

Comment 2 Greg Watson

2011-05-20 08:56:04 EDT

Build: I20110428-0848

Comment 3 Curtis Windatt

2011-05-20 09:07:22 EDT

Could be a duplicate or have the same root cause as bug 342512 (Verified in I20110514-0800).

Comment 4 Dani Megert

2011-05-20 09:10:24 EDT

Greg, could you try with http://download.eclipse.org/eclipse/downloads/drops/I20110519-1138/index.php?

Comment 5 Greg Watson

2011-05-20 10:10:43 EDT

I'm unable to reproduce with I20110514-080. Thanks!

Closing bug.