Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346639

Summary:	[call hierarchy] "Refresh View" should bind to F5 like run search again
Product:	[Eclipse Project] JDT	Reporter:	Philippe Marschall <philippe.marschall>
Component:	UI	Assignee:	JDT-UI-Inbox <jdt-ui-inbox>
Status:	ASSIGNED ---	QA Contact:
Severity:	enhancement
Priority:	P5	CC:	daniel_megert, markus.kell.r
Version:	3.7
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	185517
Bug Blocks:

Description Philippe Marschall

2011-05-20 07:12:28 EDT

Build Identifier: I20110428-0848

In the 'Search' view the search again action (org.eclipse.search2.internal.ui.SearchAgainAction
) is bound to F5. This is very convenient. However the refresh view action (org.eclipse.jdt.internal.ui.callhierarchy.RefreshViewAction
) in the 'Call Hierarchy' view is not bound at all. It would be nice if this was bound to F5 as well.

Reproducible: Always

Steps to Reproduce:
1. open the call hierarchy view on a method.
2. change some of the users to not use this method
3. hit F5 in the call hierarchy view

Comment 1 Dani Megert

2011-05-20 08:01:14 EDT

Makes sense.

Comment 2 Markus Keller

2011-05-20 09:14:19 EDT

Like in most other views, the File > Refresh (F5) is bound to refresh the selected element in the Call Hierarchy view. Furthermore, some views (including the Call Hierarchy) refresh the whole view when nothing is selected (bug 323690).

That the Search view always refreshes the whole view is the exception, not the rule. The change we could make here is to add a new command "Refresh View" to refresh the whole view (but this wouldn't be bound to F5 by default).

Comment 3 Markus Keller

2011-05-20 09:25:29 EDT

To make the command useful, we would also have to add a key binding context "In Java Call Hierarchy View". Otherwise, a user could still not change the F5 behavior in the CH without removing F5 from the normal refresh command.

However, we can only add a context after bug 185517 has been fixed.

Comment 4 Dani Megert

2011-05-20 10:02:23 EDT

(In reply to comment #2)
> Like in most other views, the File > Refresh (F5) is bound to refresh the
> selected element in the Call Hierarchy view. Furthermore, some views (including
> the Call Hierarchy) refresh the whole view when nothing is selected (bug
> 323690).
Indeed. I got tricked by the (correctly) missing 'F5' hint in the toolbar button hover.