Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346615

Summary: Simple way to disable breakpoint and access breakpoint properties
Product: [Eclipse Project] JDT Reporter: Praveen <pinnamur>
Component: DebugAssignee: Michael Rennie <Michael_Rennie>
Status: VERIFIED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: markus.kell.r, Michael_Rennie, pawel.1.piech, pinnamur
Version: 3.7Keywords: api, noteworthy
Target Milestone: 3.8 M6   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 71406    
Bug Blocks: 360588, 374153    
Attachments:
Description Flags
patch
none
Patch that uses IToggleBreakpointsTargetExtension2
none
Patch for jdt debug that implements opening breakpoint properties dialog using toggleBreakpointsItneractive.
none
platform patch
none
JDT patch none

Description Praveen CLA 2011-05-20 05:47:39 EDT 
I am heavily relied on disabling breakpoints and at many instances, accessing breakpoints properties (for setting conditions). The current way of doing these tasks are accessing the context menu of the breakpoint and choosing the appropriate menu-item. When I start doing these tasks repeatedly for multiple breakpoints at the same time, I am obsessed with the current way.

I believe we can simplify these common tasks like - 
1) Disable breakpoint : Ctrl+Click the breakpoint.
2) Access the breakpoint properties : Alt+Click the breakpoint.

Alternatively, is there any better way of doing these tasks ?
Comment 1 Michael Rennie CLA 2011-05-20 10:23:42 EDT 
This enhancement would require a fix to bug 71406, so that we can use modifier keys in the editor.
Comment 2 Michael Rennie CLA 2012-01-24 15:28:22 EST 
Created attachment 210010 [details]
patch

I know its test day, but I just could not resist trying to make this work...

The patch provides support for:

1. Ctrl+double click -> enables / disables
2. Shift+double click -> opens the properties dialog on the breakpoint
Comment 3 Pawel Piech CLA 2012-01-26 18:49:14 EST 
Created attachment 210161 [details]
Patch that uses IToggleBreakpointsTargetExtension2

I would like to hitch a feature I just filed in bug 369856 onto this bug ;-)  Also, I think we should defer opening of the breakpoint properties dialog to the breakpoint model.  CDT creates a custom context object for the properties dialog, and Wind River has a completely custom dialog.
Comment 4 Michael Rennie CLA 2012-01-30 12:13:43 EST 
(In reply to comment #3)
> I would like to hitch a feature I just filed in bug 369856 onto this bug ;-) 

I think it would be better if we kept the two features separate.
Comment 5 Pawel Piech CLA 2012-02-01 11:47:16 EST 
Created attachment 210384 [details]
Patch for jdt debug that implements opening breakpoint properties dialog using toggleBreakpointsItneractive.

This patch uses the new API in bug 369856 to open breakpoint properties dialog when toggle action is invoked in editor with Shift key pressed.
Comment 6 Pawel Piech CLA 2012-02-03 19:04:16 EST 
Comment on attachment 210384 [details]
Patch for jdt debug that implements opening breakpoint properties dialog using toggleBreakpointsItneractive.

With the latest patch for bug 369856 no JDT plugin changes are needed.
Comment 7 Michael Rennie CLA 2012-02-15 17:01:44 EST 
Created attachment 211074 [details]
platform patch

This is a patch for platform debug that provides the new hooks to pass along the event to toggle adapters.

The patch has a new API IToggleBreakpointsTargetExtension2 that has two new methods: canToggleBreakpointsWithEvent and toggleBreakpointsWithEvent.
Comment 8 Michael Rennie CLA 2012-02-15 17:02:32 EST 
Created attachment 211075 [details]
JDT patch

This patch implements the new API from the platform patch
Comment 9 Pawel Piech CLA 2012-02-16 00:02:41 EST 
+1 To commit these as is with one minor request: as a JDT user I'd prefer to have the Control key (MOD1) bring up dialog, and have Shift (MOD2) enable/disable.  We use Control as a modifier to some of the launch menus to open the launch config. dialog, so this seems more consistent to me.
Comment 11 Pawel Piech CLA 2012-03-13 18:20:56 EDT 
I'll definitely use this feature :-)