Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346499

Summary: Too many errors not filtered in I20110519-0800
Product: [Eclipse Project] PDE Reporter: Olivier Thomann <Olivier_Thomann>
Component: API ToolsAssignee: Olivier Thomann <Olivier_Thomann>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: curtis.windatt.public, daniel_megert, Michael_Rennie
Version: 3.7Flags: Michael_Rennie: review+
curtis.windatt.public: review+
daniel_megert: review+
Target Milestone: 3.7 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Proposed fix none

Description Olivier Thomann CLA 2011-05-19 12:02:05 EDT 
The ant task is not filtering problems as it should. I believe the ant task should not check the equality of the resource path in the reported problem. When running the ant task on binary, there is no such thing as a resource path for the corresponding problem.
If the id, problem arguments and type name are matching, then the problem should be filtered.
Comment 1 Olivier Thomann CLA 2011-05-19 12:02:30 EDT 
Daniel, this is the issue that is causing the pb with the current reports.
Comment 2 Olivier Thomann CLA 2011-05-19 12:04:57 EDT 
Created attachment 196134 [details]
Proposed fix

The fix is to use a specific method to match the filtered problem and the reported problem inside the ant api filter store.
I also wonder how api usage issues are properly filtered for the same reason. But given the time of the change, I would only focus on fixing that specific issue.
Comment 3 Olivier Thomann CLA 2011-05-19 12:05:32 EDT 
Michael, please review.
Comment 4 Olivier Thomann CLA 2011-05-19 12:05:49 EDT 
Curtis, please review.
Comment 5 Curtis Windatt CLA 2011-05-19 13:08:39 EDT 
+1

Debugging through the task it is clear that the filters don't apply because the resource doesn't match.  The fix corrects this, just checking the type name.
Comment 6 Michael Rennie CLA 2011-05-19 13:21:18 EDT 
+1 looks fine
Comment 7 Olivier Thomann CLA 2011-05-19 13:26:17 EDT 
Daniel, if you want the fix for RC3, you will need to provide a +1 as well.
Comment 8 Dani Megert CLA 2011-05-20 03:13:54 EDT 
Can you explain why it worked up to RC1 (actually even RC2-I20110518-0800) but now we see those issues since I20110519-0800, e.g. http://download.eclipse.org/eclipse/downloads/drops/I20110519-1138/apitools/apitoolsverifications/html/index.html?
Comment 9 Olivier Thomann CLA 2011-05-20 09:23:19 EDT 
I20110518-0800 was not using RC1 api tools bundles. Previous versions missing some problems and could not filter right others.
The patch is pretty straight forward and I ran a test successfully with it.
Comment 10 Dani Megert CLA 2011-05-20 09:54:28 EDT 
The fix looks good.
Comment 11 Olivier Thomann CLA 2011-05-20 10:28:20 EDT 
Released for 3.7RC3.
Comment 12 Olivier Thomann CLA 2011-05-20 10:28:36 EDT 
Released.
Comment 13 Dani Megert CLA 2011-05-23 03:33:19 EDT 
(In reply to comment #12)
> Released.

That's not what I see: I see the code is *committed* to HEAD but it does not seem to be released (Team > Release) into the builds.
Comment 14 Dani Megert CLA 2011-05-26 01:24:06 EDT 
Verified in I20110525-0800.