Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346487

Summary:	No selection feedback for non-resizable diagram nodes
Product:	[Modeling] Graphiti	Reporter:	Shenxue Zhou <shenxue.zhou>
Component:	Core	Assignee:	Michael Wenz <michael.wenz>
Status:	CLOSED FIXED	QA Contact:
Severity:	blocker
Priority:	P1	CC:	matthias.gorning, michael.wenz
Version:	0.8.0	Flags:	michael.wenz: indigo+
Target Milestone:	0.8.0
Hardware:	All
OS:	All
Whiteboard:	Indigo RC2 theme_bugs

Description Shenxue Zhou

2011-05-19 11:45:42 EDT

We recently adopted Graphiti Indigo RC1 build and I'm seeing regression on selection feedback. In my diagram, nodes are composed of an image with a label. I use an invisible rectangle as the GA for the container shape. When I select a node, I don't see any selection feedback. So there is no way to tell which node is selected in the diagram.

This seems to be a regression. In the March Indigo M6 build, there was a dotted orange rectangle as selection feedback for such nodes.

Without selection feedback, it's very frustrating to edit the diagram. Could you take a look at this issue ASAP?

Thanks!

Comment 1 Shenxue Zhou

2011-05-19 12:22:16 EDT

I need to clarify the nodes in my diagram are *NOT* resizable. 

Checking the history of ShapeXYLayoutEditPolicy class, the regression seemed to be introduced when the following bug is fixed:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=341180 (Graphiti fails to handle resize after custom feature addition in the tutorial)

On contrary to what's stated in bug fix note for bug 341180, GFResizableEditPolicy class doesn't handle the selection feedback for non-resizable nodes correctly. It merely returns empty list for selection handles for non-resizable nodes.

Comment 2 Michael Wenz

2011-05-20 04:11:25 EDT

Right, in such a case there is no selection feedback any more. The intention of the fix for bug 341180 was to hide the resize handles only.

Comment 3 Michael Wenz

2011-05-20 04:16:38 EDT

Reproducable with the Line object in the Sketch test tool

Comment 4 Michael Wenz

2011-05-20 04:45:48 EDT

I have changed the creation of the selection handles in a way that for non-resible shapes the orange frame without the handles is drawn again.

I have checked-in the change to head to enable you to test the fix. Nevertheless please treat this fix as preliminary, since I need this change to be reviewed by another commiter on Monday (we need this since we are in RC2) for any side effects I may have not noticed.

I will update this bug as soon as a build containing this is available.

Comment 5 Michael Wenz

2011-05-20 07:11:27 EDT

A first RC2 version containing this fix is now available.
- Update site: http://download.eclipse.org/graphiti/updates/milestones/S-0.8.0RC2-201105200834
- Archive: http://download.eclipse.org/graphiti/archives/milestones/org.eclipse.graphiti.site_0.8.0RC2.201105200834.zip

The final version of RC2 will come next Wednesday.

Comment 6 Shenxue Zhou

2011-05-20 12:12:16 EDT

(In reply to comment #5)
> A first RC2 version containing this fix is now available.
> - Update site:
> http://download.eclipse.org/graphiti/updates/milestones/S-0.8.0RC2-201105200834
> - Archive:
> http://download.eclipse.org/graphiti/archives/milestones/org.eclipse.graphiti.site_0.8.0RC2.201105200834.zip
> 
> The final version of RC2 will come next Wednesday.

I just tried out the fix by getting Graphiti plugins from the CVS head. Now I see dotted orange rectangle around non-resizable nodes when they are selected.

I'll try out your RC2 build.

Thanks so much for your quick response!

Comment 7 Michael Wenz

2011-05-23 06:35:37 EDT

Ok, thanks! I will let another colleague verify the fix.

Michael

Comment 8 Michael Wenz

2011-06-24 08:47:56 EDT

Part of Graphiti Indigo 0.8.0