Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346339

Summary:

Performance optimization for large inline binary text sections

Product:

z_Archived

Reporter:

Blaise Doughan <blaise.doughan>

Component:

Eclipselink

Assignee:

Nobody - feel free to take it <nobody>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

eclipselink.oxm-inbox

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Core - Fix	none
Core - Fix	none
Core - Fix	none
MOXy - Test Cases	none
Core - Fix	none
MOXy - Test Cases	none
MOXy - Test Cases	none
Core - Fix	none
Core - Fix (Phase 2)	none

Description Blaise Doughan

2011-05-18 16:10:32 EDT

Currently an exception is being thrown in MOXy when converting large inline binary sections.

Comment 1 Blaise Doughan

2011-05-18 16:16:15 EDT

Created attachment 196047 [details]
Core - Fix

Comment 2 Blaise Doughan

2011-05-19 14:32:22 EDT

Created attachment 196150 [details]
Core - Fix

Comment 3 Blaise Doughan

2011-05-19 15:23:03 EDT

Created attachment 196158 [details]
Core - Fix

Comment 4 Blaise Doughan

2011-05-25 16:56:03 EDT

Created attachment 196610 [details]
MOXy - Test Cases

Comment 5 Blaise Doughan

2011-05-25 16:56:18 EDT

Created attachment 196611 [details]
Core - Fix

Comment 6 Blaise Doughan

2011-05-26 10:34:34 EDT

Created attachment 196666 [details]
MOXy - Test Cases

Comment 7 Blaise Doughan

2011-05-26 13:31:16 EDT

Created attachment 196685 [details]
MOXy - Test Cases

Comment 8 Blaise Doughan

2011-05-26 13:31:54 EDT

Created attachment 196686 [details]
Core - Fix

Comment 9 Blaise Doughan

2011-05-26 14:05:59 EDT

Fix checked into trunk at rev:  9466

Code reviewed by Matt MacIvor

Fix Description:
- Added a call back on XMLReader that allows the implementor to obtain converted types from a CharSequence.  This is an optimization that can be leveraged when supported by the underlying parser.
- Introduced a new interface ExtendedContentHandler that extends ContentHandler with a new method characters(CharSequence) and modified all of MOXy's content handlers to implement this new interface.
- Modified UnmarshalRecords handling of characters to cover both char[] and charSequence.
- Added a new method (parseCharactersEvent) in XMLStreamReaderReader that allows users to override the handling of characters sections.
- Enhanced StrBuffer to implement CharSequence

Comment 10 Blaise Doughan

2011-05-27 13:52:03 EDT

Some outside tests through NPE with this fix.

Comment 11 Blaise Doughan

2011-05-27 13:53:31 EDT

Created attachment 196792 [details]
Core - Fix (Phase 2)

Moved the special handling of CharSequence from UnmarshalRecord to XMLInlineBinaryHandler.

Comment 12 Blaise Doughan

2011-05-27 13:55:49 EDT

2nd part of fix checked into trunk at rev:  9472

Comment 13 Eclipse Webmaster

2022-06-09 10:14:10 EDT

The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink

Comment 14 Eclipse Webmaster

2022-06-09 10:30:26 EDT

The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink