Bugzilla – Full Text Bug Listing
| Summary: | error: setRepos(Repository[]) is undefined | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Frank Becker <eclipse> |
| Component: | Mylyn | Assignee: | Alvaro Sanchez-Leon <alvaro.sanchez-leon> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | lmcbout, sebastien.dubois, steffen.pingel |
| Version: | unspecified | ||
| Target Milestone: | 0.9 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Frank Becker
Egit.core introduced a non backward compatible change on the CommitOperation class on release 0.12. R4E still uses the 0.11 version of it, and the hudson nightly build still uses an earlier version than 0.12 Fixing R4E to use the 0.12 will break the nightly build, Steffen, how far back shall we support egit changes ? if any as eGit is still in Incubation .. (In reply to comment #1) > Egit.core introduced a non backward compatible change on the CommitOperation > class on release 0.12. > > R4E still uses the 0.11 version of it, and the hudson nightly build still uses > an earlier version than 0.12 According to the pom it is building against the latest release available from the update site. > Fixing R4E to use the 0.12 will break the nightly build, We should always support the latest release. > Steffen, how far back shall we support egit changes ? if any as eGit is still in > Incubation .. My sense is that we should support the version that is Indigo. (In reply to comment #2) >According to the pom it is building against the latest release available from the update site. I went ahead and push the changes to align the o.e.m.reviews.r4e.core.tests to the latest egit (0.12) and the hudson build is now broken, which pom specifies to take the latest available from the update site ? Reverted change to recover the Hudson build The pom.xml in the top-level directory of the git repository specifies these repositories, i.e. the build should run against 0.12: [INFO] Adding repository (cached) http://download.eclipse.org/releases/indigo/ [INFO] Adding repository (cached) http://download.eclipse.org/mylyn/snapshots/weekly/ [INFO] Adding repository (cached) http://download.eclipse.org/tools/orbit/downloads/drops/S20110515001817/repository/ [INFO] Adding repository (cached) http://download.eclipse.org/egit/updates/ In addition to making the change you should set a corresponding version constraint in the feature and bundle manifests to ensure that Tycho resolves to the expected version. I see the repository definition, however it does not seem to pick egit 0.12 I tried with the changes as seen in build #398 (broken ) and then modified dependencies (see build #399) And the build was still broken, I then reverted back in build #401 to get automatic builds going again. Any ideas of what else might be missing ? Are you sure that these changes were made in EGit 0.12? Looking at the history it seems that the EGit changes are only in the nightly builds. Upps, yes, I see the change in commit 2f724143.... 2011-05-12, my mistake, I thought I was using the 12.1 tag when I saw the compilation error, I must have been using master. Looking at the change, it seems eGit does not longer support impacting multiple repos with the same commit, which makes sense to me. we could discuss changes on eGit but at this stage on the release for Indigo, I don't think is worthy, from the Mylyn Reviews side, when do we switch 0.8 to compile with egit 1.0.0 (Indigo release ) ? I assume we can do this as soon as the build branch for 0.8 is created .. As for the master branch we can wait for the release of egit 1.0.0, and we update the dependencies right after they become available, Hudson will mail me as soon as the build brakes Let me know if this sounds reasonable.. so I can go ahead and close this issue. Waiting for the hudson nightly build to align the code I have updated the pom to build against EGit 1.0.0. Can you please push the fix to master? Alvaro, I cherry-picked your original commit and pushed the changes. I'll also port this to e_3_7_m_3_6_x branch since 0.8 should target EGit 1.0.0. |