Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 346316

Summary: Canceling a build should not log an error
Product: [Eclipse Project] PDE Reporter: Olivier Thomann <Olivier_Thomann>
Component: API ToolsAssignee: Olivier Thomann <Olivier_Thomann>
Status: VERIFIED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: curtis.windatt.public
Version: 3.7   
Target Milestone: 3.8 M3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Proposed fix none

Description Olivier Thomann CLA 2011-05-18 14:27:04 EDT 
Using I20110517-2200 (4.1 I-build).

I canceled a build and got:
org.eclipse.core.runtime.OperationCanceledException
	at org.eclipse.pde.api.tools.internal.util.Util.updateMonitor(Util.java:1081)
	at org.eclipse.pde.api.tools.internal.provisional.comparator.ApiComparator.compare(ApiComparator.java:475)
	at org.eclipse.pde.api.tools.internal.builder.BaseApiAnalyzer.checkCompatibility(BaseApiAnalyzer.java:1296)
	at org.eclipse.pde.api.tools.internal.builder.BaseApiAnalyzer.checkCompatibility(BaseApiAnalyzer.java:508)
	at org.eclipse.pde.api.tools.internal.builder.BaseApiAnalyzer.analyzeComponent(BaseApiAnalyzer.java:248)
	at org.eclipse.pde.api.tools.internal.builder.IncrementalApiBuilder.build(IncrementalApiBuilder.java:272)
	at org.eclipse.pde.api.tools.internal.builder.IncrementalApiBuilder.build(IncrementalApiBuilder.java:230)
	at org.eclipse.pde.api.tools.internal.builder.ApiAnalysisBuilder.build(ApiAnalysisBuilder.java:391)
	at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:728)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:199)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:239)
	at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:292)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:295)
	at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:351)
	at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:374)
	at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:143)
	at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:241)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

I don't expect anything in the .log file as I canceled the build on purpose.
Comment 1 Olivier Thomann CLA 2011-05-18 15:07:57 EDT 
Created attachment 196037 [details]
Proposed fix
Comment 2 Curtis Windatt CLA 2011-05-18 15:56:05 EDT 
Fix is well contained, but it is very late in 3.7.  Is this something you were wanting for 3.7 Olivier?
Comment 3 Olivier Thomann CLA 2011-05-18 15:59:56 EDT 
Definitely not (not critical), but since the fix was simple, I wanted to put it there for future reference. 3.8 is perfectly fine.
Comment 4 Curtis Windatt CLA 2011-10-03 17:06:43 EDT 
Applied the fix to master.
Comment 5 Curtis Windatt CLA 2011-10-25 14:18:45 EDT 
Verified in I20111021-1625